HIGH: PlayerInputComponent manual overwrite breaks hook chain

[TheCodingDad-TisonK]

Severity: HIGH

File: src/main.lua:483
Multiplayer: No
Fix Complexity: MODERATE
Confidence: 100% (source-verified)

Description

Manual overwrite of PlayerInputComponent.registerActionEvents instead of Utils.overwrittenFunction. Any mod loaded after this one that also hooks the same function will be silently skipped.

Fix

Refactor to use Utils.overwrittenFunction to preserve the hook chain.

---

Source: Consolidated Bug Review 2026-07-26, NPF-002

[github-actions]

Hey @TheCodingDad-TisonK, welcome to the village! 🏡

Thanks for opening this issue — the neighbors have been notified. @TheCodingDad-TisonK will stop by as soon as possible.

While you wait, please make sure you've included:

• You are running the latest version of NPC Favor (visible in the mod manager)
• Your issue includes the relevant [NPC Favor] lines from log.txt
  • Log location: Documents/My Games/FarmingSimulator2025/log.txt
  • Search for [NPC Favor] and paste the relevant section here
• If this involves a specific NPC (Mia, Hans, etc.) — note their name and what quest or interaction triggered the problem
• You have searched existing issues to avoid duplicates

Note: Issues without a log snippet are difficult to investigate and may be closed. A log is almost always required to reproduce bugs.

[TheCodingDad-TisonK]

Investigated: Confirmed. main.lua manually overwrote PlayerInputComponent.registerActionEvents instead of using Utils.overwrittenFunction. Fixed in commit 2cc22b2 on development. Awaiting PR merge to main.

[TheCodingDad-TisonK]

Resolved in development branch, merged to main via PR #69.