CRIT: Favor time limit display broken - wrong field name

[TheCodingDad-TisonK]

Severity: CRITICAL

File: src/gui/NPCFavorManagementDialog.lua:232,237,252,258
Multiplayer: No
Fix Complexity: TRIVIAL
Confidence: 100% (source-verified)

Description

References favor.expiryTime — this field does not exist on favor objects. Actual field is favor.expirationGameTime (set in NPCFavorSystem.lua:209,1325).

Impact

getTimeRemainingText() always returns "No time limit" and getTimeUrgency() always returns 0 (green). Favor expiration timers are completely invisible to the player. The favor WILL expire, but the player has no UI indication.

Fix

Replace favor.expiryTime with favor.expirationGameTime at all 4 lines (232, 237, 252, 258).

---

Source: Consolidated Bug Review 2026-07-26, NPF-001

[github-actions]

Hey @TheCodingDad-TisonK, welcome to the village! 🏡

Thanks for opening this issue — the neighbors have been notified. @TheCodingDad-TisonK will stop by as soon as possible.

While you wait, please make sure you've included:

• You are running the latest version of NPC Favor (visible in the mod manager)
• Your issue includes the relevant [NPC Favor] lines from log.txt
  • Log location: Documents/My Games/FarmingSimulator2025/log.txt
  • Search for [NPC Favor] and paste the relevant section here
• If this involves a specific NPC (Mia, Hans, etc.) — note their name and what quest or interaction triggered the problem
• You have searched existing issues to avoid duplicates

Note: Issues without a log snippet are difficult to investigate and may be closed. A log is almost always required to reproduce bugs.

[TheCodingDad-TisonK]

Investigated: Confirmed. NPCFavorManagementDialog.lua referenced avor.expiryTime (non-existent field) instead of avor.expirationGameTime. Fixed in commit db17d31 on development — all 4 occurrences now use the correct field name. Awaiting PR merge to main.

[TheCodingDad-TisonK]

Resolved in development branch, merged to main via PR #69.