Skip to content

feat(compose): Enhancement to saved apk name #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
vippium opened this issue Dec 12, 2024 · 3 comments
Closed
3 tasks done

feat(compose): Enhancement to saved apk name #2347

vippium opened this issue Dec 12, 2024 · 3 comments
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@vippium
Copy link

vippium commented Dec 12, 2024

Feature description

Instead of saving the apk with the original package name, the manager should save it with patches version and youtube version like this: youtube-rvx_v19.34.42-patches_v3.0.0-dev.1 instead of com.google.android.youtube. This naming scheme is followed by RVX manager (and maybe RV Manager too).

Motivation

It will enhance the naming scheme which will help user to identify the correct compiled apk. And help him to find which version he patched last time.
Useful for testing different version compatibility with the patches that which version starts breaking it.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@vippium vippium added the Feature request Requesting a new feature that's not implemented yet label Dec 12, 2024
@Axelen123 Axelen123 added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Dec 12, 2024
@Ushie
Copy link
Member

Ushie commented Jan 27, 2025

With the support of patching with multiple patch bundles, this becomes more complicated, so it should take a more generic approach

What about appname_version_patched.apk? No mention of ReVanced or the patch bundles version

@vippium
Copy link
Author

vippium commented Jan 27, 2025

No mention of ReVanced or the patch bundles version

It will also be a good one. But if possible to add bundle version will be best. If not possible, then it can also be a good one.

@oSumAtrIX
Copy link
Member

ReVanced is the patcher which applies to any bundle. Adding it to the name is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

No branches or pull requests

5 participants