Using std::min and std::max

[ssstroke]

I think it is better for readability to use std::min and std::max functions instead of a ternary operator. Here are some examples:

// ... Book version

if (t0 < t1) {
    if (t0 > ray_t.min) ray_t.min = t0;
    if (t1 < ray_t.max) ray_t.max = t1;
} else {
    if (t1 > ray_t.min) ray_t.min = t1;
    if (t0 < ray_t.max) ray_t.max = t0;
}

// ...

and

// ... Alternative approach

if (t0 < t1)
{
    ray_t.min = std::max(ray_t.min, t0);
    ray_t.max = std::min(ray_t.max, t1);
}
else
{
    ray_t.min = std::max(ray_t.min, t1);
    ray_t.max = std::min(ray_t.max, t0);
}

// ...

Also:

// ... Book version

interval(const interval& a, const interval& b) {
    // Create the interval tightly enclosing the two input intervals.
    min = a.min <= b.min ? a.min : b.min;
    max = a.max >= b.max ? a.max : b.max;
}

and

// ... Alternative approach

Interval(const Interval& a, const Interval& b)
{
    this->min = std::min(a.min, b.min);
    this->max = std::max(a.max, b.max);
}

I understand that it is mostly a matter of taste, but I think using ternary operator hurts readability a bit and makes you read into the code more than it needs to. I think it is especially true for not very experienced and new-school programmers (which is who I consider myself to be).

Thank you so much for the book and for keeping it alive!

[hollasch]

Ref #444 and #1488.