Replies: 1 comment 2 replies
-
Good grief — someone who actually read the There's a better way to accomplish this in Markdeep, so I've delimited all free-standing URLs in the three books, and posted a separate review. Feel free to comment there (linked to from your original review): #1347 In the future, the easiest route is to just make the changes directly off the main repository. You might not have permissions for this, so let me know and I can add you as a contributor. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In the Contributing guidelines, under
Pull Request
:Create your changes in a feature branch (or fork)
. When creating a fork (The typical way I've contributed before), there's no way to add the "rt-contributors" as reviewers, as you'd need to make them collaborators of the project. Is the preferred way to make a PR directly against this repo?Include a one-line summary change at the bottom of the current development section in the changelog.
Is this still the case? I assume it's against theCHANGELOG.md
but i haven't seen any evidence of other PR's making changes to that.Beta Was this translation helpful? Give feedback.
All reactions