Skip to content

Design for "hash arrays" needs to clearer #249

@thejayps

Description

@thejayps

This issue captures several defects/comments recorded during the review of #230:
"M. https://github.com/Ravenbrook/mps/blob/branch/2023-05-31/hash-arrays/code/poolamc.c#L961-L962 "defer the size accounting" with what intention? (Could refer to design.mps.strategy section.) rule.generic.clear (Please see
#233 (comment) when editing this. RB 2023-05-07)"
from #230 (review)

"My only comment is that the mechanism that setting
MPS_KEY_AP_HASH_ARRAYS to true uses to not contribute to nursery space
is not described. But perhaps it is correct that implementation
details (which could change) are not discussed."
from #230 (review)

"NQ. Is ramping documented? If so, we could mention in the manual that hash arrays are ramping." from #230 (comment)

Also: "comment1: nice improvements to the documentation noted in the past could be relevant https://www.ravenbrook.com/project/mps/issue/job004109/" from
#230 (comment) could be relevant if it still applies. This needs investigating.

Metadata

Metadata

Assignees

No one assigned

    Labels

    optionalWill cause failures / of benefit. Worth assigning resources.review-raiseIssue raised from proc.review.edit

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions