Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linters to enforce code consistency #26

Open
rakeshgm opened this issue Mar 5, 2025 · 1 comment
Open

Add linters to enforce code consistency #26

rakeshgm opened this issue Mar 5, 2025 · 1 comment
Labels
scheduled Scheduled for next release
Milestone

Comments

@rakeshgm
Copy link
Member

rakeshgm commented Mar 5, 2025

To maintain consistent code quality and enforce best practices, ramenctl should adopt linting tools. Adding linters will ensure a standardised coding style across the project. This could also server as first step towards introducing CI to validate the code changes.

Linters

golangci-lint

Start with this configuration:
https://github.com/nirs/kubectl-gather/blob/main/.golangci.yaml

It was taken from Cobra, and some linters were disabled due to issue in the current code. We want to enable the disabled linters in this repo.

If the current code does not pass the lint job you can disable the linters until it pass. In the next step enable each linter by fixing the issues in the current code.

@nirs nirs added the scheduled Scheduled for next release label Mar 5, 2025
@nirs nirs added this to the v0.3.0 milestone Mar 5, 2025
@OdedViner
Copy link

I will take it @rakeshgm @nirs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduled Scheduled for next release
Projects
None yet
Development

No branches or pull requests

3 participants