Skip to content

Commit 2281227

Browse files
kumarsgoyalBenamarMk
authored andcommitted
add update permission for apps resources
- Include `update` verb in RBAC for Deployments, ReplicaSets, and StatefulSets to allow necessary controller updates during reconciliation. Signed-off-by: kumarsgoyal <kumar.sgoyal@gmail.com>
1 parent 6eb6550 commit 2281227

2 files changed

Lines changed: 96 additions & 3 deletions

File tree

dr1.log

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
2025-10-28T06:49:42.568Z INFO setup controller/ramenconfig.go:62 loading Ramen configuration from {"file": "/config/ramen_manager_config.yaml"}
2+
2025-10-28T06:49:42.569Z INFO setup cmd/main.go:106 controller type {"type": "dr-cluster"}
3+
2025-10-28T06:49:42.769Z INFO vrg controller/volumereplicationgroup_controller.go:71 Adding VolumeReplicationGroup controller
4+
2025-10-28T06:49:42.769Z INFO vrg controller/volumereplicationgroup_controller.go:114 VolSync enabled; adding owns and watches
5+
2025-10-28T06:49:42.769Z INFO vrg controller/volumereplicationgroup_controller.go:2313 Kube object protection enabled; watch kube objects requests
6+
2025-10-28T06:49:42.877Z INFO setup cmd/main.go:192 VolSync enabled, setup ReplicationGroupSource and ReplicationGroupDestination controllers
7+
2025-10-28T06:49:42.887Z INFO setup cmd/main.go:296 starting manager
8+
2025-10-28T06:49:42.887Z INFO manager/server.go:83 starting server {"name": "health probe", "addr": "[::]:8081"}
9+
2025-10-28T06:49:42.887Z INFO controller-runtime.metrics server/server.go:208 Starting metrics server
10+
2025-10-28T06:49:42.887Z INFO controller-runtime.metrics server/server.go:247 Serving metrics server {"bindAddress": "127.0.0.1:9289", "secure": false}
11+
I1028 06:49:43.188267 1 leaderelection.go:257] attempting to acquire leader lease ramen-system/dr-cluster.ramendr.openshift.io...
12+
I1028 06:49:43.199074 1 leaderelection.go:271] successfully acquired lease ramen-system/dr-cluster.ramendr.openshift.io
13+
2025-10-28T06:49:43.199Z DEBUG events recorder/recorder.go:104 ramen-dr-cluster-operator-67dff877f5-j6whc_8fb14325-4f27-4240-a032-ccc530684e3d became leader {"type": "Normal", "object": {"kind":"Lease","namespace":"ramen-system","name":"dr-cluster.ramendr.openshift.io","uid":"b077912a-2c95-4cc7-9b34-295b19465177","apiVersion":"coordination.k8s.io/v1","resourceVersion":"5038"}, "reason": "LeaderElection"}
14+
2025-10-28T06:49:43.199Z INFO controller/controller.go:246 Starting EventSource {"controller": "protectedvolumereplicationgrouplist", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ProtectedVolumeReplicationGroupList", "source": "kind source: *v1alpha1.ProtectedVolumeReplicationGroupList"}
15+
2025-10-28T06:49:43.199Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupdestination", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupDestination", "source": "kind source: *v1.VolumeSnapshot"}
16+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.Recipe"}
17+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1alpha1.NetworkFenceClass"}
18+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.VolumeReplicationGroup"}
19+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.VolumeReplication"}
20+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.VolumeGroupReplication"}
21+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationDestination"}
22+
2025-10-28T06:49:43.200Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationSource"}
23+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1.Restore"}
24+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationGroupSource"}
25+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationGroupDestination"}
26+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1.PersistentVolumeClaim"}
27+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.VolumeReplication"}
28+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.VolumeGroupReplication"}
29+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1.ConfigMap"}
30+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationDestination"}
31+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationSource"}
32+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationGroupDestination"}
33+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1alpha1.ReplicationGroupSource"}
34+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "source": "kind source: *v1.Backup"}
35+
2025-10-28T06:49:43.201Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1.StorageClass"}
36+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource", "source": "kind source: *v1beta1.VolumeGroupSnapshot"}
37+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1alpha1.DRClusterConfig"}
38+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource", "source": "kind source: *v1alpha1.ReplicationGroupSource"}
39+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource", "source": "kind source: *v1.PersistentVolumeClaim"}
40+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource", "source": "kind source: *v1alpha1.ReplicationSource"}
41+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1alpha1.VolumeGroupReplicationClass"}
42+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1.VolumeSnapshotClass"}
43+
2025-10-28T06:49:43.202Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1alpha1.VolumeReplicationClass"}
44+
2025-10-28T06:49:43.203Z INFO controller/controller.go:246 Starting EventSource {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "source": "kind source: *v1beta1.VolumeGroupSnapshotClass"}
45+
2025-10-28T06:49:43.203Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupdestination", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupDestination", "source": "kind source: *v1alpha1.ReplicationGroupDestination"}
46+
2025-10-28T06:49:43.203Z INFO controller/controller.go:246 Starting EventSource {"controller": "replicationgroupdestination", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupDestination", "source": "kind source: *v1alpha1.ReplicationDestination"}
47+
2025-10-28T06:49:43.567Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:193 Create event for PersistentVolumeClaim
48+
2025-10-28T06:49:43.569Z INFO configmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:159 Update in ramen-dr-cluster-operator-config configuration map
49+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
50+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
51+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
52+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
53+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
54+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
55+
2025-10-28T06:49:43.668Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
56+
2025-10-28T06:49:43.768Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
57+
2025-10-28T06:49:43.770Z INFO controller/drclusterconfig_controller.go:464 failed processing DRClusterConfig mapping, failed to find DRClusterConfig
58+
2025-10-28T06:49:43.770Z INFO controller/controller.go:186 Starting Controller {"controller": "protectedvolumereplicationgrouplist", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ProtectedVolumeReplicationGroupList"}
59+
2025-10-28T06:49:43.770Z INFO controller/controller.go:195 Starting workers {"controller": "protectedvolumereplicationgrouplist", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ProtectedVolumeReplicationGroupList", "worker count": 1}
60+
2025-10-28T06:49:43.865Z INFO controller/controller.go:186 Starting Controller {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig"}
61+
2025-10-28T06:49:43.865Z INFO controller/controller.go:195 Starting workers {"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "worker count": 1}
62+
2025-10-28T06:49:43.865Z INFO controller/controller.go:186 Starting Controller {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup"}
63+
2025-10-28T06:49:43.865Z INFO controller/controller.go:195 Starting workers {"controller": "volumereplicationgroup", "controllerGroup": "ramendr.openshift.io", "controllerKind": "VolumeReplicationGroup", "worker count": 50}
64+
2025-10-28T06:49:43.865Z INFO controller/controller.go:186 Starting Controller {"controller": "replicationgroupdestination", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupDestination"}
65+
2025-10-28T06:49:43.865Z INFO controller/controller.go:195 Starting workers {"controller": "replicationgroupdestination", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupDestination", "worker count": 50}
66+
2025-10-28T06:49:43.866Z INFO controller/controller.go:186 Starting Controller {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource"}
67+
2025-10-28T06:49:43.866Z INFO controller/controller.go:195 Starting workers {"controller": "replicationgroupsource", "controllerGroup": "ramendr.openshift.io", "controllerKind": "ReplicationGroupSource", "worker count": 50}
68+
2025-10-28T06:49:58.271Z INFO configmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:159 Update in ramen-dr-cluster-operator-config configuration map
69+
2025-10-28T06:49:58.271Z INFO configmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:159 Update in ramen-dr-cluster-operator-config configuration map
70+
2025-10-28T06:49:59.749Z INFO drcc controller/drclusterconfig_controller.go:76 reconcile enter {"drcc": "dr1", "rid": "988781b7"}
71+
2025-10-28T06:49:59.898Z INFO drcc controller/drclusterconfig_controller.go:124 reconcile exit {"drcc": "dr1", "rid": "988781b7"}
72+
2025-10-28T06:49:59.899Z INFO drcc controller/drclusterconfig_controller.go:76 reconcile enter {"drcc": "dr1", "rid": "b2d66ce7"}
73+
2025-10-28T06:49:59.911Z INFO drcc controller/drclusterconfig_controller.go:124 reconcile exit {"drcc": "dr1", "rid": "b2d66ce7"}
74+
2025-10-28T06:50:22.043Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:193 Create event for PersistentVolumeClaim
75+
2025-10-28T06:50:22.079Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
76+
2025-10-28T06:50:22.079Z INFO pvcmap.VolumeReplicationGroup controller/vrg_volrep.go:487 Skipping handling of VR as PVC is not bound {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "pvcPhase": "Pending"}
77+
2025-10-28T06:50:22.079Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:282 Not Requeuing {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "oldPVC Phase": "Pending", "newPVC phase": "Pending"}
78+
2025-10-28T06:50:22.773Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
79+
2025-10-28T06:50:22.774Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:252 Reconciling due to change in spec {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc"}
80+
2025-10-28T06:50:22.801Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
81+
2025-10-28T06:50:22.802Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:258 Reconciling due to phase change {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "before": "Pending", "after": "Bound"}
82+
2025-10-28T06:58:08.333Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
83+
2025-10-28T06:58:08.357Z INFO pvcmap.VolumeReplicationGroup controller/vrg_volrep.go:501 Skipping PVC, as it is marked for deletion and not yet protected {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc"}
84+
2025-10-28T06:58:08.358Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:282 Not Requeuing {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "oldPVC Phase": "Bound", "newPVC phase": "Bound"}
85+
2025-10-28T06:58:13.140Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:217 PVC Delete {"namespace": "e2e-disapp-recipe-hooks-deploy-rbd-busybox", "name": "busybox-pvc"}
86+
2025-10-28T07:14:30.861Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:193 Create event for PersistentVolumeClaim
87+
2025-10-28T07:14:30.876Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
88+
2025-10-28T07:14:30.876Z INFO pvcmap.VolumeReplicationGroup controller/vrg_volrep.go:487 Skipping handling of VR as PVC is not bound {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "pvcPhase": "Pending"}
89+
2025-10-28T07:14:30.878Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:282 Not Requeuing {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "oldPVC Phase": "Pending", "newPVC phase": "Pending"}
90+
2025-10-28T07:14:31.400Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
91+
2025-10-28T07:14:31.400Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:252 Reconciling due to change in spec {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc"}
92+
2025-10-28T07:14:31.420Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:211 Update event for PersistentVolumeClaim
93+
2025-10-28T07:14:31.421Z INFO pvcmap.VolumeReplicationGroup controller/volumereplicationgroup_controller.go:258 Reconciling due to phase change {"pvc": "e2e-disapp-recipe-hooks-deploy-rbd-busybox/busybox-pvc", "before": "Pending", "after": "Bound"}

internal/controller/volumereplicationgroup_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -381,9 +381,9 @@ func filterPVC(reader client.Reader, pvc *corev1.PersistentVolumeClaim, log logr
381381
// +kubebuilder:rbac:groups=storage.k8s.io,resources=volumeattachments,verbs=get;list;watch
382382
// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch
383383
// +kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch
384-
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch
385-
// +kubebuilder:rbac:groups=apps,resources=replicasets,verbs=get;list;watch
386-
// +kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=get;list;watch
384+
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;update
385+
// +kubebuilder:rbac:groups=apps,resources=replicasets,verbs=get;list;watch;update
386+
// +kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=get;list;watch;update
387387
// +kubebuilder:rbac:groups=core,resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
388388
// +kubebuilder:rbac:groups=core,resources=persistentvolumes,verbs=get;list;watch;update;patch;create
389389
// +kubebuilder:rbac:groups=volsync.backube,resources=replicationdestinations,verbs=get;list;watch;create;update;patch;delete

0 commit comments

Comments
 (0)