-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 404 & 500 page #164
Comments
@coke there is a 404.html that is generated and is in the root directory, but it is not being served by NGINX. So, the default NGINX 404 handler needs changing. |
Also look at new-raku 404 |
See #171 |
There are templates for 404 and 500 errors fitting the design, please do use them: http://164.90.207.89:10010/baka See https://github.com/Altai-man/docs.raku.org/blob/master/templates/404.crotmp and https://github.com/Altai-man/docs.raku.org/blob/master/templates/500.crotmp for templates. |
The 404 page is created in the build and the website is now using it. Note that it seems to follow the text of the original site more than the update here. I have some edits for that in mind. I can add the website rules for the 500 error once that page is generated during the build. |
The 404 currently used on the site is generated from a But note the text on Altai-man's page 'this error is already been reported' What does this mean. How is it reported? |
Please see my suggested version in #178 |
I assume "it's in the logs"; we should definitely be reporting out on the logs, or at least investigating occasionally. Odds of getting a 500 on the static site are slim, though. |
What changes did you want? |
The ones I submitted in the PR? |
@coke I missed the PR request. Just approved. |
The idea was that the engine will be smart enough to, on replying to a 404/500 request, report the error somewhere so that we could check what broke or what's the URL in question someone couldn't access, hence the line. |
perhaps using raku doc's 404 as a model, we need to add a 404 handler page instead of relying on the nginx handler.
Related to Raku/doc#4214
The text was updated successfully, but these errors were encountered: