Add bt upgrade (#432)

* add bt upgrade

* implemented todos

* introduce SPEC constant

* remove legacy parsing

* fix

* fix

* simplify code

* upgrade test files

* remove empty keys

* updated test yamls

* fix

* fix name

* use newer version of bt upgrade

* improve bt upgrade

* add missing dir

* [upgrade] Remove comments from limits if both limits are the new default

* [upgrade] Ad-hoc import for CommentedMap and CommentedSeq

* try to insert testdata before data

* try to preserve the right comments

* try to preserve the right comments

* [upgrade] Improve preserving of comments when removing keys

* [upgrade] Improve replacing of keys at their original position

* fix errors

* rerun upgrade

* readd output validator dir

* [upgrade] Only write generators.yaml when it changed

---------

Co-authored-by: Maarten Sijm <[email protected]>

Author: mzuenni

bin/config.py

@@ -7,6 +7,8 @@
 from collections.abc import Mapping, Sequence
 from typing import Final, Literal, Optional
 
+SPEC_VERSION: Final[str] = "2023-07-draft"
+
 # return values
 RTV_AC: Final[int] = 42
 RTV_WA: Final[int] = 43

bin/export.py

@@ -172,7 +172,7 @@ def add_file(path, source):
 
     # DOMjudge does not support 'type' in problem.yaml nor 'output_validator_args' in testdata.yaml yet.
     # TODO: Remove this once it does.
-    if not config.args.kattis and not problem.settings.is_legacy():
+    if not config.args.kattis:
         yaml_path = export_dir / "problem.yaml"
         yaml_data = [yaml_path.read_text(), "\nvalidation:"]
         if problem.custom_output:

bin/problem.py

@@ -39,6 +39,7 @@
 import solve_stats
 import download_submissions
 import stats
+import upgrade
 import validate
 import signal
 
@@ -351,6 +352,13 @@ def build_parser():
     )
     subparsers.required = True
 
+    # upgrade
+    subparsers.add_parser(
+        "upgrade",
+        parents=[global_parser],
+        help="Upgrade a problem or contest.",
+    )
+
     # New contest
     contestparser = subparsers.add_parser(
         "new_contest",
@@ -916,6 +924,11 @@ def run_parsed_arguments(args):
         else:
             config.args.testcases = []
 
+    # upgrade commands.
+    if action == "upgrade":
+        upgrade.upgrade()
+        return
+
     # Skel commands.
     if action == "new_contest":
         skel.new_contest()