New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action should fail properly #2

Closed

Benjadahl opened this issue Jan 18, 2022 · 0 comments · Fixed by #3

Assignees

Labels

Member

Benjadahl commented Jan 18, 2022

When a request fails it currently doesn't result in the action failing. This is because of the try catch block, not handling the async code properly.

Benjadahl self-assigned this

Benjadahl added the Type: Bug label

Benjadahl linked a pull request

that will close this issue

2 handle failure #3

Merged

Benjadahl closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment