squash spiffs: improve unittests

Author: Vincent Dupont

cpu/native/mtd/mtd_native.c

@@ -15,7 +15,7 @@
 
 #include "native_internal.h"
 
-#define ENABLE_DEBUG (1)
+#define ENABLE_DEBUG (0)
 #include "debug.h"
 
 static mtd_sta_t _init(mtd_dev_t *dev)

tests/unittests/tests-spiffs/tests-spiffs.c

@@ -35,6 +35,16 @@ static vfs_mount_t _test_spiffs_mount = {
     .private_data = &spiffs_desc,
 };
 
+static void test_spiffs_teardown(void)
+{
+    vfs_mount(&_test_spiffs_mount);
+    vfs_unlink("/test-spiffs/test.txt");
+    vfs_unlink("/test-spiffs/test0.txt");
+    vfs_unlink("/test-spiffs/test1.txt");
+    vfs_unlink("/test-spiffs/a/test2.txt");
+    vfs_umount(&_test_spiffs_mount);
+}
+
 static void test_spiffs_mount_umount(void)
 {
     int res;
@@ -201,17 +211,13 @@ static void tests_spiffs_readdir(void)
     res = vfs_opendir(&dirp, "/test-spiffs");
 
     vfs_dirent_t entry;
-    res = vfs_readdir(&dirp, &entry);
-    TEST_ASSERT(res == 1);
-    TEST_ASSERT_EQUAL_STRING("/test0.txt", &(entry.d_name[0]));
-
-    res = vfs_readdir(&dirp, &entry);
-    TEST_ASSERT(res == 1);
-    TEST_ASSERT_EQUAL_STRING("/test1.txt", &(entry.d_name[0]));
-
-    res = vfs_readdir(&dirp, &entry);
-    TEST_ASSERT(res == 1);
-    TEST_ASSERT_EQUAL_STRING("/a/test2.txt", &(entry.d_name[0]));
+    for (int i = 0; i < 3; i++) {
+        res = vfs_readdir(&dirp, &entry);
+        TEST_ASSERT_EQUAL_INT(1, res);
+        TEST_ASSERT(strcmp("/test0.txt", &(entry.d_name[0])) == 0 ||
+                    strcmp("/test1.txt", &(entry.d_name[0])) == 0 ||
+                    strcmp("/a/test2.txt", &(entry.d_name[0])) == 0);
+    }
 
     res = vfs_readdir(&dirp, &entry);
     TEST_ASSERT_EQUAL_INT(0, res);
@@ -295,7 +301,7 @@ Test *tests_spiffs_tests(void)
         new_TestFixture(tests_spiffs_write2),
     };
 
-    EMB_UNIT_TESTCALLER(spiffs_tests, NULL, NULL, fixtures);
+    EMB_UNIT_TESTCALLER(spiffs_tests, NULL, test_spiffs_teardown, fixtures);
 
     return (Test *)&spiffs_tests;
 }