Move Fitbit connector specific config to KafkaConnector as recommended.

Author: ewelinagr

charts/radar-fitbit-connector/templates/kafka-connect.yaml

@@ -43,24 +43,6 @@ spec:
     value.converter.schema.registry.url: {{ .Values.schema_registry }}
     internal.key.converter: "org.apache.kafka.connect.json.JsonConverter"
     internal.value.converter: "org.apache.kafka.connect.json.JsonConverter"
-    # CONNECTOR properties that configure the fitbit connector, used to create custom-config/kafka-connect.properties in the connector pod.
-    # These properties could be placed in the KafkaConnector spec.config, but in that case they will only be stored in-memory, not in the properties file.
-    name: radar-fitbit-source
-    fitbit.api.client: {{ .Values.fitbit_api_client }}
-    fitbit.api.secret: {{ .Values.fitbit_api_secret }}
-    fitbit.api.intraday: {{ .Values.includeIntradayData }}
-    fitbit.user.repository.class: org.radarbase.connect.rest.fitbit.user.{{ .Values.user_repository_class }}
-    fitbit.user.repository.url: {{ .Values.radar_rest_sources_backend_url }}
-    fitbit.user.repository.client.id: {{ .Values.oauthClientId }}
-    fitbit.user.repository.client.secret: {{ .Values.oauthClientSecret }}
-    fitbit.user.repository.oauth2.token.url: {{ .Values.managementportal_url }}/oauth/token
-    fitbit.user.poll.interval: {{ .Values.fitbit_user_poll_interval | int }}
-    fitbit.user.dir: /mnt/users
-    application.loop.interval.ms: {{ .Values.application_loop_interval_ms | quote }}
-    user.cache.refresh.interval.ms: {{ .Values.user_cache_refresh_interval_ms | quote }}
-    rest.source.base.url: {{ .Values.fitbit_api_url }}
-    rest.source.poll.interval.ms: {{ .Values.rest_source_poll_interval_ms | quote }}
-    rest.source.request.generator.class: org.radarbase.connect.rest.fitbit.request.FitbitRequestGenerator
   template:
     pod:
       metadata:

charts/radar-fitbit-connector/templates/kafka-connector.yaml

@@ -8,3 +8,20 @@ metadata:
 spec:
   class: org.radarbase.connect.rest.fitbit.FitbitSourceConnector
   tasksMax: {{ .Values.connector_num_tasks }}
+  config: # Properties that configure Fitbit source connector
+    name: radar-fitbit-source
+    fitbit.api.client: {{ .Values.fitbit_api_client }}
+    fitbit.api.secret: {{ .Values.fitbit_api_secret }}
+    fitbit.api.intraday: {{ .Values.includeIntradayData }}
+    fitbit.user.repository.class: org.radarbase.connect.rest.fitbit.user.{{ .Values.user_repository_class }}
+    fitbit.user.repository.url: {{ .Values.radar_rest_sources_backend_url }}
+    fitbit.user.repository.client.id: {{ .Values.oauthClientId }}
+    fitbit.user.repository.client.secret: {{ .Values.oauthClientSecret }}
+    fitbit.user.repository.oauth2.token.url: {{ .Values.managementportal_url }}/oauth/token
+    fitbit.user.poll.interval: {{ .Values.fitbit_user_poll_interval | int }}
+    fitbit.user.dir: /mnt/users
+    application.loop.interval.ms: {{ .Values.application_loop_interval_ms | quote }}
+    user.cache.refresh.interval.ms: {{ .Values.user_cache_refresh_interval_ms | quote }}
+    rest.source.base.url: {{ .Values.fitbit_api_url }}
+    rest.source.poll.interval.ms: {{ .Values.rest_source_poll_interval_ms | quote }}
+    rest.source.request.generator.class: org.radarbase.connect.rest.fitbit.request.FitbitRequestGenerator