Skip to content

[v2] .map is too eager in creating qrls #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wmertens opened this issue May 9, 2025 · 1 comment · Fixed by #7636 or #7637
Closed

[v2] .map is too eager in creating qrls #7572

wmertens opened this issue May 9, 2025 · 1 comment · Fixed by #7636 or #7637
Assignees
@Varixo
Labels
TYPE: bug Something isn't working VERSION: upcoming major

Comments

@wmertens
Copy link
Member

wmertens commented May 9, 2025

qwik/packages/docs/src/components/footer/footer.tsx

Lines 84 to 105 in 5b16129

export const FooterSocialLinks = component$(() => {
const socialLinks = [
{ href: 'https://qwik.dev/chat', title: 'Discord', Logo: DiscordLogo },
{ href: 'https://github.com/QwikDev/qwik', title: 'GitHub', Logo: GithubLogo },
{ href: 'https://twitter.com/QwikDev', title: 'Twitter', Logo: TwitterLogo },
{ href: 'https://bsky.app/profile/qwik.dev', title: 'Bluesky', Logo: BlueskyLogo },
];
return (
<ul class="flex gap-4 mt-4">
{socialLinks.map(({ title, href, Logo }) => (
<li key={title} class="list-none">
<a href={href} target="_blank" title={title}>
<span>
<Logo width={22} height={22} />
</span>
</a>
</li>
))}
</ul>
);
});

This causes serialization of the icons in the .map()

(at least I think so, there's a warning because of function serialization that we ignore for now)
@wmertens wmertens added TYPE: bug Something isn't working VERSION: upcoming major labels May 9, 2025
@Varixo
Copy link
Member

Varixo commented May 11, 2025

playground:
https://qwikdev-build-v2.qwik-8nx.pages.dev/playground/#f=7VfLTsJAFP2VsRsKgTZGXIgUEyE%2BIgsT3RkXRQEbqhhbFqTpv3vm3pnp9EETY9y5gKQzd87MnLmPc22nOTlt9Jp%2BUX5bZAnf8wr3XH49bF8QBnNUwASXbvQkNp9FCda%2Fzrcoa5od0htqgkXHubG%2FpixVN8f4zW5RtX5EWsZp6uZqomp%2FiVKWbPZ1ezVRtU9K13wibjMSMSPR0bWuIOotTDvwePmAmFc3xIjcb1SiIu83Y3GS9kCoL71hBlSK3gKViTCgFl%2BHMFPmwga18BRTBtCm9BDiAlR5cCofAnEVxUtDgYWrGDW4NvWE%2BwyXqkbJLmaxGTirWJas8HMwFO%2FpYOhoL8%2BsJ%2FGgwlw34y37dEjeTeT0sgxKwHEkNst9kJFprjeRwmXwAc818GQcKpkq%2F3MlkgKH65rDu2kkex1WSqFbHsIgnciEqQ7WqilEpxXZfhzpr243VzG9i3VU46fC8T5ESpOJpyUG0%2B16jcIeFFHuSs0CkJY%2BIvN7AkIRGg1ZmUseacZCsfV8PhhseQcPBRNS6EKM60nCn4gR46dQaRxnevmY%2B41CZmd8A7cEG4gj%2B7ubT6bz2%2Bmd6VZq%2FQ2x9LteSrGrHq8K3lwNj8%2Bsfu8n1bCUcP9r4V%2FUwm8

This was linked to pull requests May 23, 2025
fix: serialize less vnode data #7636
Merged
fix: don't wrap static objects with signal #7637
Merged
@Varixo Varixo closed this as completed May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Varixo Varixo

Labels
TYPE: bug Something isn't working VERSION: upcoming major
Projects
None yet
Milestone
No milestone
2 participants
@wmertens @Varixo