Skip to content

Conversation

@marmarta
Copy link
Member

prettyicons

Result of audit/icon design by Ura Design.

Remaining minor quibble: should we replace all standard ok/cancel icons? The default icon set is kind of an acquired taste.

Based on lucide.dev set, reworked and redesigned,
complete with readme.
The column was supposed to represent VM type, but in a
non-anonymous survey of core dev team, nobody could actually
say what the icons mean, and they are also duplicated
in the icon column and the template column.
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (afc1365) to head (69f2bb8).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
qubesmanager/qube_manager.py 80.00% 4 Missing ⚠️
qubesmanager/backup.py 0.00% 2 Missing ⚠️
qubesmanager/restore.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   65.82%   65.67%   -0.16%     
==========================================
  Files          18       18              
  Lines        3901     3892       -9     
==========================================
- Hits         2568     2556      -12     
- Misses       1333     1336       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qubesos-bot
Copy link

qubesos-bot commented Jan 29, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021323-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_qrexec

    • TC_00_Qrexec_whonix-gateway-17: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'

    • TC_00_Qrexec_whonix-workstation-17: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'

  • system_tests_audio

  • system_tests_audio@hw1

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_kde_gui_interactive

Failed tests

18 failures
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_qrexec

    • TC_00_Qrexec_whonix-gateway-17: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'

    • TC_00_Qrexec_whonix-workstation-17: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'

  • system_tests_audio

  • system_tests_audio@hw1

  • system_tests_storage_perf@hw1

    • integ: storage_perf (error)
      ModuleNotFoundError: No module named 'qubes.tests.integ.storage_perf'
  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (failure)
      AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-copy-notifi...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/127852#dependencies

28 fixed
  • system_tests_suspend

    • mount_and_boot_options: unnamed test (unknown)
    • mount_and_boot_options: Failed (test died)
      # Test died: no candidate needle with tag(s) 'x11' matched...
  • system_tests_backup

    • TC_10_BackupVM_whonix-gateway-17: test_110_send_to_vm_no_space (error)
      subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...

    • TC_10_BackupVM_whonix-workstation-17: test_110_send_to_vm_no_space (error)
      subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...

  • system_tests_qrexec

  • system_tests_dispvm

    • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
      AssertionError: './open-file test.txt' failed with ./open-file test...
  • system_tests_audio

  • system_tests_basic_vm_qrexec_gui_ext4

    • switch_pool: Failed (test died)
      # Test died: command 'printf "label: gpt\n,,L" | sfdisk /dev/sdb' f...
  • system_tests_qrexec_perf@hw1

    • TC_00_QrexecPerf_debian-12-xfce: test_110_simple_data_duplex (failure)
      AssertionError: '/usr/lib/qubes/tests/qrexec_perf.py --vm1=test-ins...
  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_000_list_loop (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_010_list_dm (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_012_list_dm_delayed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_013_list_dm_removed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_020_list_loop_partition (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_021_list_loop_partition_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_000_list_loop (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_001_list_loop_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_010_list_dm (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_011_list_dm_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_012_list_dm_delayed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_013_list_dm_removed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_020_list_loop_partition (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_021_list_loop_partition_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_10_Attach_whonix-gateway-17: test_000_attach_reattach (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_10_Attach_whonix-workstation-17: test_000_attach_reattach (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

  • system_tests_kde_gui_interactive

Unstable tests

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

32 tests
  • debian-12-xfce_exec: 7.78
  • debian-12-xfce_exec-root: 27.99
  • debian-12-xfce_socket: 8.52
  • debian-12-xfce_socket-root: 8.76
  • debian-12-xfce_exec-data-simplex: 46.76
  • debian-12-xfce_exec-data-duplex: 46.17
  • debian-12-xfce_exec-data-duplex-root: 65.07
  • debian-12-xfce_socket-data-duplex: 78.55
  • fedora-41-xfce_exec: 9.00 🟢 ( previous job: 21.67, improvement: 41.55%)
  • fedora-41-xfce_exec-root: 61.59 🟢 ( previous job: 74.48, improvement: 82.70%)
  • fedora-41-xfce_socket: 8.53 🟢 ( previous job: 21.26, improvement: 40.13%)
  • fedora-41-xfce_socket-root: 8.67 🟢 ( previous job: 20.89, improvement: 41.53%)
  • fedora-41-xfce_exec-data-simplex: 50.28 🟢 ( previous job: 58.71, improvement: 85.64%)
  • fedora-41-xfce_exec-data-duplex: 48.69 🟢 ( previous job: 60.49, improvement: 80.49%)
  • fedora-41-xfce_exec-data-duplex-root: 82.89 🟢 ( previous job: 92.13, improvement: 89.98%)
  • fedora-41-xfce_socket-data-duplex: 78.13 🟢 ( previous job: 83.57, improvement: 93.50%)
  • whonix-gateway-17_exec: 6.97
  • whonix-gateway-17_exec-root: 37.96
  • whonix-gateway-17_socket: 8.34
  • whonix-gateway-17_socket-root: 7.49
  • whonix-gateway-17_exec-data-simplex: 48.35
  • whonix-gateway-17_exec-data-duplex: 47.74
  • whonix-gateway-17_exec-data-duplex-root: 72.26
  • whonix-gateway-17_socket-data-duplex: 83.06
  • whonix-workstation-17_exec: 7.88
  • whonix-workstation-17_exec-root: 53.12
  • whonix-workstation-17_socket: 8.41
  • whonix-workstation-17_socket-root: 8.23
  • whonix-workstation-17_exec-data-simplex: 50.06
  • whonix-workstation-17_exec-data-duplex: 51.33
  • whonix-workstation-17_exec-data-duplex-root: 78.91
  • whonix-workstation-17_socket-data-duplex: 80.10

@marmarek marmarek merged commit a46eaa1 into QubesOS:main Feb 16, 2025
3 of 5 checks passed
marmarek added a commit to QubesOS/qubes-desktop-linux-manager that referenced this pull request Feb 17, 2025
* origin/pr/242:
  Improve dark mode readability, make icons more neutral
  Make qui-* icons gray
  Improved Global Config
  New and improved icons

related to QubesOS/qubes-manager#403

Result of audit/icon design by Ura Design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants