Skip to content

Replace numpy.fromstring with numpy.frombuffer #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Replace numpy.fromstring with numpy.frombuffer #127

merged 1 commit into from
Jun 20, 2025
+6 −6

Conversation

@alimirjamali
Copy link
Contributor

@alimirjamali alimirjamali commented Jun 8, 2025

qubesimgconverter library uses deprecated binary mode of fromstring. This form was finally removed in the recent versions of numpy. Switching to numpy.frombuffer resolves the issue.

source: numpy/numpy@491f66a#diff-71aadf0228c9cd61ea260748af1dcd4a726eea8476b8cbd667367466c1e39077R2303

@alimirjamali
Replace numpy.fromstring with numpy.frombuffer
238dd4c 
`qubesimgconverter` library uses deprecated binary mode of fromstring.
This form was finally removed in the recent versions of numpy. Switching
to `numpy.frombuffer` resolves the issue.

source: numpy/numpy@491f66a#diff-71aadf0228c9cd61ea260748af1dcd4a726eea8476b8cbd667367466c1e39077R2303
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.60%. Comparing base (673e1e9) to head (238dd4c).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files           6        6           
  Lines         952      952           
  Branches      104      104           
=======================================
  Hits          577      577           
  Misses        285      285           
  Partials       90       90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alimirjamali alimirjamali mentioned this pull request Jun 14, 2025
Merged
@marmarek marmarek added the openqa-pending PR to be tested in the next OpenQA run label Jun 17, 2025
This was referenced Jun 18, 2025
Open
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Jun 18, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062018-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_whonix

    • whonix_torbrowser: unnamed test (unknown)

    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

    • whonix_torbrowser: unnamed test (unknown)

  • system_tests_dispvm

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_whonix-gateway-17-pool: test_400_long_window_title (error)
      subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

  • system_tests_audio

  • system_tests_update@hw13

    • update2: Failed (test died)
      # Test died: command 'script -c 'qubes-vm-update --force-update --l...

  • system_tests_suspend@hw1

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/9qnlY-\d+-/...

    • suspend: Failed (test died + timed out)
      # Test died: command 'qvm-run --no-gui -p sys-net "curl -f http://h...

Failed tests

14 failures

  • system_tests_whonix

    • whonix_torbrowser: unnamed test (unknown)

    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

    • whonix_torbrowser: unnamed test (unknown)

  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

  • system_tests_dispvm

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_whonix-gateway-17-pool: test_400_long_window_title (error)
      subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

  • system_tests_audio

  • system_tests_update@hw13

    • update2: Failed (test died)
      # Test died: command 'script -c 'qubes-vm-update --force-update --l...

  • system_tests_suspend@hw1

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/9qnlY-\d+-/...

    • suspend: Failed (test died + timed out)
      # Test died: command 'qvm-run --no-gui -p sys-net "curl -f http://h...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

Unstable tests

Performance Tests

Performance degradation:

8 performance degradations
  • debian-12-xfce_exec-data-simplex: 77.16 🔺 ( previous job: 65.51, degradation: 117.78%)
  • debian-12-xfce_exec-data-duplex-root: 79.51 🔺 ( previous job: 70.01, degradation: 113.57%)
  • whonix-gateway-17_exec-data-duplex-root: 100.43 🔺 ( previous job: 90.74, degradation: 110.67%)
  • whonix-workstation-17_exec-data-duplex-root: 102.97 🔺 ( previous job: 86.00, degradation: 119.73%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 9115.00 :small_red_triangle: ( previous job: 32696.00, degradation: 27.88%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 13915.00 :small_red_triangle: ( previous job: 17102.00, degradation: 81.36%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 9522.00 :small_red_triangle: ( previous job: 11086.00, degradation: 85.89%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 288.00 :small_red_triangle: ( previous job: 1840.00, degradation: 15.65%)

Remaining performance tests:

64 tests
  • debian-12-xfce_exec: 5.56 🟢 ( previous job: 8.63, improvement: 64.39%)
  • debian-12-xfce_exec-root: 28.85 🟢 ( previous job: 29.44, improvement: 98.00%)
  • debian-12-xfce_socket: 8.32 🟢 ( previous job: 8.50, improvement: 97.88%)
  • debian-12-xfce_socket-root: 8.95 🔺 ( previous job: 8.31, degradation: 107.68%)
  • debian-12-xfce_exec-data-duplex: 74.69 🔺 ( previous job: 73.55, degradation: 101.56%)
  • debian-12-xfce_socket-data-duplex: 166.04 🔺 ( previous job: 161.35, degradation: 102.91%)
  • fedora-42-xfce_exec: 9.06
  • fedora-42-xfce_exec-root: 58.08
  • fedora-42-xfce_socket: 8.02
  • fedora-42-xfce_socket-root: 8.75
  • fedora-42-xfce_exec-data-simplex: 63.60
  • fedora-42-xfce_exec-data-duplex: 74.22
  • fedora-42-xfce_exec-data-duplex-root: 106.90
  • fedora-42-xfce_socket-data-duplex: 154.77
  • whonix-gateway-17_exec: 7.43 🔺 ( previous job: 7.34, degradation: 101.22%)
  • whonix-gateway-17_exec-root: 42.42 🔺 ( previous job: 39.57, degradation: 107.18%)
  • whonix-gateway-17_socket: 7.08 🟢 ( previous job: 7.85, improvement: 90.18%)
  • whonix-gateway-17_socket-root: 8.63 🔺 ( previous job: 7.89, degradation: 109.35%)
  • whonix-gateway-17_exec-data-simplex: 74.17 🟢 ( previous job: 77.76, improvement: 95.37%)
  • whonix-gateway-17_exec-data-duplex: 78.39 🔺 ( previous job: 78.39, degradation: 100.00%)
  • whonix-gateway-17_socket-data-duplex: 167.56 🔺 ( previous job: 161.95, degradation: 103.46%)
  • whonix-workstation-17_exec: 8.51 🔺 ( previous job: 8.27, degradation: 102.88%)
  • whonix-workstation-17_exec-root: 58.48 🔺 ( previous job: 57.61, degradation: 101.51%)
  • whonix-workstation-17_socket: 9.34 🔺 ( previous job: 8.97, degradation: 104.15%)
  • whonix-workstation-17_socket-root: 8.23 🟢 ( previous job: 9.46, improvement: 87.03%)
  • whonix-workstation-17_exec-data-simplex: 79.01 🔺 ( previous job: 74.54, degradation: 106.00%)
  • whonix-workstation-17_exec-data-duplex: 76.98 🔺 ( previous job: 74.84, degradation: 102.86%)
  • whonix-workstation-17_socket-data-duplex: 145.44 🟢 ( previous job: 160.20, improvement: 90.79%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 313007.00 :green_circle: ( previous job: 289982.00, improvement: 107.94%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 168524.00 :green_circle: ( previous job: 101988.00, improvement: 165.24%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 74837.00 :green_circle: ( previous job: 14284.00, improvement: 523.92%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1822.00 :green_circle: ( previous job: 1091.00, improvement: 167.00%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 432938.00 :green_circle: ( previous job: 289182.00, improvement: 149.71%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 134287.00 :green_circle: ( previous job: 122848.00, improvement: 109.31%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 429392.00 :small_red_triangle: ( previous job: 433654.00, degradation: 99.02%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 183134.00 :green_circle: ( previous job: 167872.00, improvement: 109.09%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103750.00 :small_red_triangle: ( previous job: 108760.00, degradation: 95.39%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 10420.00 :green_circle: ( previous job: 8874.00, improvement: 117.42%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8536.00 :green_circle: ( previous job: 6356.00, improvement: 134.30%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4391.00 :small_red_triangle: ( previous job: 4420.00, degradation: 99.34%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 368957.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 137153.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 287754.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 41883.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 80557.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2074.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8965.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1424.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 380746.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 118979.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 327884.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 63252.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 88016.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3601.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8591.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1128.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 296459.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 95123.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 254446.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 102849.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81262.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2296.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7921.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2192.00

This was referenced Jun 18, 2025
Merged
Draft
Merged
Merged
@marmarek marmarek merged commit 238dd4c into QubesOS:main Jun 20, 2025
2 of 3 checks passed
@qubesos-bot qubesos-bot mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marmarek marmarek marmarek approved these changes

Assignees

No one assigned

Labels

openqa-pending PR to be tested in the next OpenQA run

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alimirjamali @codecov-commenter @qubesos-bot @marmarek