Skip to content

Commit 4ed3d5a

Browse files
committed
Merge remote-tracking branch 'origin/pr/567'
* origin/pr/567: Do not include rpath in release builds rpm: fix directories ownership rpm: use /usr/etc/security instead of /etc/security on openSUSE
2 parents 56f5b0b + d69cda3 commit 4ed3d5a

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

misc/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ BINDIR ?= /usr/bin
22
DATADIR ?= /usr/share
33
SYSLIBDIR ?= /lib
44
LIBDIR ?= /usr/lib
5+
ETCSECURITYDIR ?= /etc/security
56
QUBESLIBDIR := $(LIBDIR)/qubes
67
UDEVRULESDIR := $(SYSLIBDIR)/udev/rules.d
78
QUBESDATADIR := $(DATADIR)/qubes
@@ -52,7 +53,7 @@ install:
5253
install -m 0755 -d $(DESTDIR)/etc/xdg/xfce4/xfconf/xfce-perchannel-xml
5354
install -m 0644 -t $(DESTDIR)/etc/xdg/xfce4/xfconf/xfce-perchannel-xml xfce4-notifyd.xml
5455
install -m 0644 -t $(DESTDIR)/etc/xdg/xfce4/xfconf/xfce-perchannel-xml displays.xml
55-
install -m 0644 -D -t $(DESTDIR)/etc/security/limits.d 90-qubes-core.conf
56+
install -m 0644 -D -t $(DESTDIR)$(ETCSECURITYDIR)/limits.d 90-qubes-core.conf
5657
install -m 0644 -D -t $(DESTDIR)/usr/lib/sysctl.d 20-qubes-core.conf
5758

5859
marker-vm: marker-vm.in

qubes-rpc/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@ LDLIBS := -lqubes-rpc-filecopy -lqubes-pure
1919

2020
all: vm-file-editor qopen-in-vm qfile-agent qfile-unpacker tar2qfile qubes-fs-tree-check bin-qfile-unpacker
2121

22+
ifdef DEVEL_BUILD
2223
# Ensure that these programs can find their shared libraries,
2324
# even when installed in e.g. a TemplateBasedVM to somewhere other
2425
# than /usr.
2526
vm-file-editor qopen-in-vm qfile-agent qfile-unpacker tar2qfile qubes-fs-tree-check: LDFLAGS += '-Wl,-rpath,$$ORIGIN/../../$$LIB'
2627
# This is installed in /usr/bin, not /usr/lib/qubes, so it needs a different rpath.
2728
bin-qfile-unpacker: LDFLAGS += '-Wl,-rpath,$$ORIGIN/../$$LIB'
29+
endif
30+
2831
bin-qfile-unpacker: qfile-unpacker.o gui-fatal.o
2932
$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS)
3033
qubes-fs-tree-check: LDLIBS := -lqubes-pure

rpm_spec/core-agent.spec.in

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ BuildRequires: sudo
220220
BuildRequires: dracut
221221
BuildRequires: ca-certificates
222222
BuildRequires: qubes-core-qrexec
223+
BuildRequires: xdg-desktop-portal
223224
%endif
224225
# for update-mime-database
225226
BuildRequires: shared-mime-info
@@ -490,6 +491,10 @@ usermod -L root
490491

491492
%install
492493

494+
%if 0%{?is_opensuse}
495+
export ETCSECURITYDIR=/usr/etc/security
496+
%endif
497+
493498
make install-vm PYTHON=%{__python3} "DESTDIR=$RPM_BUILD_ROOT" SYSTEM_DROPIN_DIR=%{_unitdir} SYSLIBDIR=/usr/lib ENABLE_SELINUX=%with_selinux
494499
make -C app-menu DESTDIR=$RPM_BUILD_ROOT install
495500
make -C boot DESTDIR=$RPM_BUILD_ROOT install
@@ -985,7 +990,11 @@ rm -f %{name}-%{version}
985990
%config(noreplace) /etc/dconf/db/local.d/dpi
986991
%config(noreplace) /etc/xdg/xfce4/xfconf/xfce-perchannel-xml/xfce4-notifyd.xml
987992
%config(noreplace) /etc/xdg/xfce4/xfconf/xfce-perchannel-xml/displays.xml
993+
%if 0%{?is_opensuse}
994+
%config(noreplace) /usr/etc/security/limits.d/90-qubes-core.conf
995+
%else
988996
%config(noreplace) /etc/security/limits.d/90-qubes-core.conf
997+
%endif
989998
/usr/lib/sysctl.d/20-qubes-core.conf
990999
%_udevrulesdir/50-qubes-mem-hotplug.rules
9911000
%_unitdir/[email protected]/90-session-stop-timeout.conf
@@ -1317,6 +1326,7 @@ The Qubes core startup configuration for SystemD init.
13171326
%dir %_unitdir/sysinit.target.d
13181327
%_unitdir/sysinit.target.d/30_qubes.conf
13191328
%_unitdir/systemd-nsresourced.service.d/30_qubes.conf
1329+
%dir %_unitdir/systemd-nsresourced.socket.d
13201330
%_unitdir/systemd-nsresourced.socket.d/30_qubes.conf
13211331
%dir %_userunitdir/*.service.d
13221332
%_userunitdir/tracker-extract-3.service.d/30_qubes.conf

0 commit comments

Comments
 (0)