You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there some reason why the project cannot use the langchain.schema.vectorstore.VectorStore abstraction in lieu of Ragna's VectorDatabaseSourceStorage class? LangChain has so many adapters already written, including ones for Chroma and LanceDB, that it seems like a shame not to leverage that work here in some fashion.
Right now our policy is to only have components in the main library that don't require additional infrastructure. Meaning, requirements in the form of packages that needed to be installed as well as environment variables to be set is fine. We can easily check those and thus give the user an indication if their configuration is "valid".
For infrastructure this is not so easy. How would we check if some instance of whatever vector store is running on your cluster?
I agree that this policy is a little restrictive and we might change it later on. At least we should have a "recipe catalog" for these use cases.
Anyway, this policy currently excludes most of the vector stores that langchain has.
We had very bad experiences with langchain in the past. Everything is buried under multiple layers of abstraction and really hard to properly configure if you want to go beyond the defaults. Peeking at their implementation, I see that some of our pain points that we had ~6 months ago are resolved.
Still, just from my quick peek I see "standardization" issues, that would make it hard for us to reuse:
langchain Chroma puts all documents into one collection where we have a new collection per chat:
I don't see a hard barrier here that would prevent us from actually re-using their code. However, given the difficulties doing that and on the flip side the simplicity of our implementation, I currently don't see a reason for doing that.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Is there some reason why the project cannot use the
langchain.schema.vectorstore.VectorStore
abstraction in lieu of Ragna'sVectorDatabaseSourceStorage
class? LangChain has so many adapters already written, including ones for Chroma and LanceDB, that it seems like a shame not to leverage that work here in some fashion.See also:
https://api.python.langchain.com/en/latest/schema/langchain.schema.vectorstore.VectorStore.html
https://python.langchain.com/docs/integrations/vectorstores
Beta Was this translation helpful? Give feedback.
All reactions