Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 does not support typing.no_type_check [REPLACEMENT ISSUE] #781

Closed
asottile opened this issue Apr 3, 2021 · 7 comments
Closed

Flake8 does not support typing.no_type_check [REPLACEMENT ISSUE] #781

asottile opened this issue Apr 3, 2021 · 7 comments

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

The original issue

Id: 697
Title: Flake8 does not support typing.no_type_check

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:

TODO

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @liiight on Nov 28, 2020, 08:41

changed the description

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Nov 28, 2020, 09:15

please follow the issue template, notably:

<!--
*************************************************************************
NOTE: flake8 is a linting framework and does not implement any checks

if you are reporting a problem with a particular check, please track down
the plugin which implements that check.

some common ones:
- F###: https://github.com/pycqa/pyflakes
- E###, W###: https://github.com/pycqa/pycodestyle
*************************************************************************
-->

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @liiight on Nov 28, 2020, 10:11

Thanks, I apologize for opening this here

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Nov 28, 2020, 10:15

an aside, I'd be very careful about using libraries which override type annotations to have custom behaviours -- they're all likely to break in python3.10 (or with from __future__ import annotations)

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @liiight on Nov 28, 2020, 10:18

hmm, good tip. I'll point the library author to it.
Thanks!

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Nov 28, 2020, 10:20

you may also want to suggest PEP 593

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @liiight on Nov 28, 2020, 10:32

Thanks again.
I opened PyCQA/pyflakes#595, hopefully in the correct place this time.

I just want to point out that the wording the discenrs between flake8 and the checks that uses it could maybe be simplified or worded differently.
Something like:

NOTE: flake8 is a linting framework and does not implement any checks

Checks occur via plugins to the flake8 framework, and are not part of it's core.
If you are reporting a problem with a particular check, please track down
the plugin which implements that check. You can do that via its error code prefix letter.

Some common ones:
- F###: https://github.com/pycqa/pyflakes
- E###, W###: https://github.com/pycqa/pycodestyle

@asottile asottile closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant