Skip to content

Commit 18ad928

Browse files
authored
Merge pull request #192 from PublicisSapient/ticket/182-elevate-linter-warnings-to-errors
(#182) Elevate current linter warnings to errors
2 parents 0192867 + 70af345 commit 18ad928

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

.eslintrc.json

+1-8
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
"sourceType": "module",
1717
"ecmaVersion": 12
1818
},
19-
"rules": {
20-
"no-undef": "warn",
21-
"no-unused-vars": "warn"
22-
},
2319
"ignorePatterns": [
2420
"node_modules",
2521
"enable-node-libs",
@@ -38,10 +34,7 @@
3834
"plugins": ["import", "node", "promise"],
3935
"overrides": [
4036
{
41-
"files": ["*.test.js", "test-config.js"],
42-
"rules": {
43-
"no-undef": "warn"
44-
}
37+
"files": ["*.test.js", "test-config.js"]
4538
}
4639
]
4740
}

.husky/pre-commit

+3
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@
99
npx git-format-staged -f 'prettier --ignore-unknown --stdin-filepath "{}"' '*.js' '*.jsx' '*.less' '*.md' '*.json' '*.html' '*.php' '*.sh'
1010

1111
# If you have issues when running the npx command in an IDE, you should try running the command in the terminal instead. This issue is due to the PATH values not being set as expected in the IDE in order for npx to be recognized. See https://stackoverflow.com/questions/67115897/vscode-github-desktop-pre-commit-hook-npx-command-not-found for more information.
12+
13+
# Run eslint
14+
npm run eslint && npm run stylelint

css/tabs.css

-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
.zoltan {
2-
this: that;
3-
}
41
#tabs h2 {
52
margin: 0.5em 0;
63
}

0 commit comments

Comments
 (0)