Skip to content

Commit 70e9569

Browse files
konardclaude
andcommitted
fix(ci): fix CI/CD pipeline failures
Root cause analysis: 1. Root package.json missing 'check' script - CI calls 'pnpm check' which didn't exist 2. vibecode-linter uses 'npx tsc' and 'npx biome' internally for dependency checks, but in pnpm workspaces these commands fail: - 'npx tsc' shows warning and fails - 'npx biome' installs wrong package (biome@0.3.3 instead of @biomejs/biome) 3. Third-party packages in node_modules have broken type declarations 4. eslint.config.mts was included in TypeScript project, causing type errors from untyped ESLint plugins Changes: - Add missing 'check' script to root package.json - Update CI workflow to install TypeScript and Biome globally (workaround for vibecode-linter npx issue) - Enable skipLibCheck to skip type checking of node_modules (required because eslint-plugin-codegen, @effect/rpc, ast-types have broken types) - Remove eslint.config.mts from tsconfig include (reverting to working state before commit 420d655 where it wasn't included) The vibecode-linter maintainers should be notified to support pnpm workspaces by detecting the package manager and using 'pnpm exec' instead of 'npx'. Fixes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 04e9941 commit 70e9569

4 files changed

Lines changed: 13 additions & 4 deletions

File tree

.github/workflows/check.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,23 @@ jobs:
4141
- uses: actions/checkout@v4
4242
- name: Install dependencies
4343
uses: ./.github/actions/setup
44+
# vibecode-linter uses npx internally for dependency checks
45+
# In pnpm workspaces, npx doesn't find local packages correctly
46+
# Install TypeScript and Biome globally as a workaround
47+
# See: https://github.com/ton-ai-core/vibecode-linter/issues (pending issue)
48+
- name: Install global linter dependencies
49+
run: npm install -g typescript @biomejs/biome
4450
- run: pnpm lint
4551

4652
test:
47-
name: Test
53+
name: Test
4854
runs-on: ubuntu-latest
4955
timeout-minutes: 10
5056
steps:
5157
- uses: actions/checkout@v4
5258
- name: Install dependencies
5359
uses: ./.github/actions/setup
60+
# vibecode-linter uses npx internally for dependency checks (lint:tests runs first)
61+
- name: Install global linter dependencies
62+
run: npm install -g typescript @biomejs/biome
5463
- run: pnpm test

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
],
1010
"scripts": {
1111
"build": "pnpm --filter @effect-template/app build",
12+
"check": "pnpm --filter @effect-template/app check",
1213
"dev": "pnpm --filter @effect-template/app dev",
1314
"lint": "pnpm --filter @effect-template/app lint",
1415
"lint:tests": "pnpm --filter @effect-template/app lint:tests",

packages/app/tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
"src/**/*",
1414
"tests/**/*",
1515
"vite.config.ts",
16-
"vitest.config.ts",
17-
"eslint.config.mts"
16+
"vitest.config.ts"
1817
],
1918
"exclude": ["dist", "node_modules"]
2019
}

tsconfig.base.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"allowSyntheticDefaultImports": true,
2222
"resolveJsonModule": true,
2323
"isolatedModules": true,
24-
"skipLibCheck": false,
24+
"skipLibCheck": true,
2525
"forceConsistentCasingInFileNames": true,
2626
"plugins": [{ "name": "@effect/language-service" }]
2727
}

0 commit comments

Comments
 (0)