fix(app): use mode-aware create test helpers

Author: rikohomeless

packages/app/tests/docker-git/app-ready-create-fixture.ts

@@ -1,7 +1,11 @@
 import type { Dispatch, SetStateAction } from "react"
 import { expect, vi } from "vitest"
 
-import { type CreateFlowView, createInitialFlowView } from "../../src/docker-git/menu-create-shared.js"
+import {
+  type CreateFlowView,
+  createInitialFlowView,
+  resolveCreateDisplaySteps
+} from "../../src/docker-git/menu-create-shared.js"
 import type { CreateInputs, CreateStep } from "../../src/docker-git/menu-types.js"
 import type { submitCreateInputs } from "../../src/web/actions-projects.js"
 import type { GithubAuthStatus } from "../../src/web/api.js"
@@ -165,7 +169,7 @@ export const createSettingsFlowViewAtStep = (
 ): CreateFlowView => ({
   ...createSettingsFlowView(),
   buffer,
-  step: resolveRequiredCreateStepIndex(stepName)
+  step: resolveRequiredCreateStepIndex(stepName, resolveCreateDisplaySteps())
 })
 
 const createActionFrame = (

packages/app/tests/docker-git/app-ready-create.test.ts

@@ -20,6 +20,7 @@ import {
 import { expectedOutDirForRepoUrl, repositoryCreateInputArbitrary } from "./create-flow-test-helpers.js"
 
 const submitCreateInputsMock = vi.hoisted(() => vi.fn<typeof submitCreateInputs>())
+const testProjectsRoot = "/home/dev/.docker-git"
 
 vi.mock("../../src/web/actions-projects.js", () => ({
   submitCreateInputs: submitCreateInputsMock
@@ -151,7 +152,7 @@ describe("app-ready-create", () => {
 
         expect(submitCreateInputsMock).toHaveBeenCalledTimes(1)
         expectQuickCreateInputs(submitCreateInputsMock, {
-          outDir: expectedOutDirForRepoUrl(repoUrl),
+          outDir: expectedOutDirForRepoUrl(repoUrl, testProjectsRoot),
           repoRef: expectedRepoRef,
           repoUrl
         })

packages/app/tests/docker-git/create-flow-test-helpers.ts

@@ -9,7 +9,8 @@ import {
   createInitialFlowView,
   type CreateModeFlowView,
   type DisplayModeFlowView,
-  resolveCreateDisplaySteps
+  resolveCreateDisplaySteps,
+  resolveCreateFlowSteps
 } from "../../src/docker-git/menu-create-shared.js"
 import type { CreateStep } from "../../src/docker-git/menu-types.js"
 
@@ -38,8 +39,8 @@ export const repositoryCreateInputArbitrary = fc.record({
     : `https://github.com/${owner}/${repo}/tree/${branch}`
 }))
 
-export const expectedOutDirForRepoUrl = (repoUrl: string): string =>
-  `/home/dev/.docker-git/${deriveRepoPathParts(resolveRepoInput(repoUrl).repoUrl).pathParts.join("/")}`
+export const expectedOutDirForRepoUrl = (repoUrl: string, projectsRoot: string): string =>
+  `${projectsRoot}/${deriveRepoPathParts(resolveRepoInput(repoUrl).repoUrl).pathParts.join("/")}`
 
 export const expectCreateContinueView = (
   next: ReturnType<typeof advanceCreateFlow>
@@ -61,8 +62,11 @@ export const expectCreateCompleteInputs = (
   return next.inputs
 }
 
-export const resolveRequiredCreateStepIndex = (stepName: CreateStep): number => {
-  const step = resolveCreateDisplaySteps().indexOf(stepName)
+export const resolveRequiredCreateStepIndex = (
+  stepName: CreateStep,
+  steps: ReadonlyArray<CreateStep>
+): number => {
+  const step = steps.indexOf(stepName)
   if (step === -1) {
     throw new TypeError(`expected Create step: ${stepName}`)
   }
@@ -120,9 +124,12 @@ export function createFlowViewAtStep(
   stepName: CreateStep,
   buffer = "draft"
 ): CreateFlowView {
+  const steps = view.mode === "display"
+    ? resolveCreateDisplaySteps()
+    : resolveCreateFlowSteps(view.values)
   return {
     ...view,
     buffer,
-    step: resolveRequiredCreateStepIndex(stepName)
+    step: resolveRequiredCreateStepIndex(stepName, steps)
   }
 }