Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Revive additional subdag verification #2646

Open
vicsn opened this issue Mar 12, 2025 · 2 comments
Open

[Feature] Revive additional subdag verification #2646

vicsn opened this issue Mar 12, 2025 · 2 comments
Assignees

Comments

@vicsn
Copy link
Collaborator

vicsn commented Mar 12, 2025

🚀 Feature

See:
#2615
#2645

@raychu86
Copy link
Contributor

The issue is explained here - https://github.com/ProvableHQ/snarkVM/pull/2615/files#r1991933662.

It was a sort of "off-by-one" error, where the author of the certificate was accidentally not included as part of the quorum calculation.

@acoglio
Copy link
Contributor

acoglio commented Mar 12, 2025

I got "duped" into that too. I had to push a patch to ProvableHQ/snarkOS#3537. I propose to rename BatchCertificate::signatures() to BatchCertificate::endorsements().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants