Guard updating of registers identifier by ConsensusVersion::V12

Author: vicsn

console/network/src/consensus_heights.rs

@@ -45,7 +45,7 @@ pub enum ConsensusVersion {
     V10 = 10,
     /// V11: Expand array size limit to 512 and introduce ECDSA signature verification opcodes.
     V11 = 11,
-    /// V12: Prevent connection to forked nodes.
+    /// V12: Prevent connection to forked nodes, update FinalizeRegisters function_name for constructors.
     V12 = 12,
 }
 

synthesizer/process/src/finalize.rs

@@ -240,7 +240,14 @@ fn finalize_constructor<N: Network, P: FinalizeStorage<N>>(
     // Get the constructor types.
     let constructor_types = stack.get_constructor_types()?.clone();
 
-    let identifier = Identifier::<N>::from_str("constructor")?;
+    // Set the FinalizeRegisters function name for constructors.
+    // Before ConsensusVersion::V12, this was wrongly using the program id as function name.
+    let consensus_version = N::CONSENSUS_VERSION(state.block_height())?;
+    let identifier = if consensus_version >= ConsensusVersion::V12 {
+        Identifier::<N>::from_str("constructor")?
+    } else {
+        *stack.program_id().name()
+    };
 
     // Initialize the finalize registers.
     let mut registers = FinalizeRegisters::new(state, transition_id, identifier, constructor_types, nonce);