Skip to content

Commit 0ccd938

Browse files
d4rkr00tmarijnh
authored andcommitted
Enforce min version of w3c-keyname to be 1.1.8
Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too). It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts. Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package... FIX: Upgrade `w3c-keyname` dependency to version 1.1.8 to prevent users getting stuck with a buggy version. Issue #1
1 parent b44e43d commit 0ccd938

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"url": "git://github.com/prosemirror/prosemirror-keymap.git"
1717
},
1818
"dependencies": {
19-
"w3c-keyname": "^1.1.0",
19+
"w3c-keyname": "^1.1.8",
2020
"prosemirror-state": "^1.0.0"
2121
},
2222
"devDependencies": {

0 commit comments

Comments
 (0)