rust: Deny extern declarations without specifying an ABI

SlyMarbo · SlyMarbo · commit e49d92fc6a58 · 2022-07-03T10:09:54.000+01:00
Signed-off-by: SlyMarbo &lt;the.sly.marbo@googlemail.com&gt;
diff --git a/bootloader/lib.rs b/bootloader/lib.rs
@@ -26,6 +26,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/cpu/lib.rs b/kernel/cpu/lib.rs
@@ -16,6 +16,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(asm_const)]
diff --git a/kernel/drivers/pci/lib.rs b/kernel/drivers/pci/lib.rs
@@ -24,6 +24,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/drivers/serial/lib.rs b/kernel/drivers/serial/lib.rs
@@ -35,6 +35,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/drivers/virtio/lib.rs b/kernel/drivers/virtio/lib.rs
@@ -55,6 +55,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(const_btree_new)]
diff --git a/kernel/filesystem/lib.rs b/kernel/filesystem/lib.rs
@@ -21,6 +21,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/interrupts/lib.rs b/kernel/interrupts/lib.rs
@@ -76,6 +76,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(abi_x86_interrupt)]
diff --git a/kernel/lib.rs b/kernel/lib.rs
@@ -56,6 +56,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![allow(unused_crate_dependencies)] // This is to allow the doc references above.
 #![feature(alloc_error_handler)]
diff --git a/kernel/memory/heap/lib.rs b/kernel/memory/heap/lib.rs
@@ -29,6 +29,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(const_mut_refs)]
diff --git a/kernel/memory/lib.rs b/kernel/memory/lib.rs
@@ -54,6 +54,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/memory/mmio/lib.rs b/kernel/memory/mmio/lib.rs
@@ -63,6 +63,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(decl_macro)]
diff --git a/kernel/memory/physmem/lib.rs b/kernel/memory/physmem/lib.rs
@@ -58,6 +58,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/memory/segmentation/lib.rs b/kernel/memory/segmentation/lib.rs
@@ -31,6 +31,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/memory/virtmem/lib.rs b/kernel/memory/virtmem/lib.rs
@@ -31,6 +31,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(const_mut_refs)]
diff --git a/kernel/multitasking/lib.rs b/kernel/multitasking/lib.rs
@@ -31,6 +31,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(binary_heap_retain)]
diff --git a/kernel/multitasking/process/loader/lib.rs b/kernel/multitasking/process/loader/lib.rs
@@ -16,6 +16,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/network/lib.rs b/kernel/network/lib.rs
@@ -25,6 +25,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 #![feature(const_btree_new)]
diff --git a/kernel/power/lib.rs b/kernel/power/lib.rs
@@ -19,6 +19,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/random/lib.rs b/kernel/random/lib.rs
@@ -57,6 +57,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/storage/lib.rs b/kernel/storage/lib.rs
@@ -16,6 +16,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/time/lib.rs b/kernel/time/lib.rs
@@ -25,6 +25,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/utils/align/lib.rs b/kernel/utils/align/lib.rs
@@ -16,6 +16,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/utils/bitmap_index/lib.rs b/kernel/utils/bitmap_index/lib.rs
@@ -36,6 +36,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/utils/pretty/lib.rs b/kernel/utils/pretty/lib.rs
@@ -19,6 +19,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/utils/spin/lib.rs b/kernel/utils/spin/lib.rs
@@ -17,6 +17,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/kernel/utils/tar/lib.rs b/kernel/utils/tar/lib.rs
@@ -27,6 +27,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/shared/bootinfo/lib.rs b/shared/bootinfo/lib.rs
@@ -22,6 +22,7 @@
 #![deny(improper_ctypes)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/shared/crypto/chacha20/lib.rs b/shared/crypto/chacha20/lib.rs
@@ -68,6 +68,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/shared/crypto/sha256/lib.rs b/shared/crypto/sha256/lib.rs
@@ -58,6 +58,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/tools/crate-lints/main.go b/tools/crate-lints/main.go
@@ -32,6 +32,7 @@ var lints = []string{
 	"deprecated_in_future",
 	"keyword_idents",
 	"macro_use_extern_crate",
+	"missing_abi",
 	"unused_crate_dependencies",
 	"unsafe_code",
 }
diff --git a/tools/plan/gentests/rust/lib.rs b/tools/plan/gentests/rust/lib.rs
@@ -14,6 +14,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)] // Testss use `transmute`.
 #![deny(unused_crate_dependencies)]
 
diff --git a/user/firefly/lib.rs b/user/firefly/lib.rs
@@ -16,6 +16,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/user/initial-workload/lib.rs b/user/initial-workload/lib.rs
@@ -14,6 +14,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![forbid(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 
diff --git a/user/test-workload/lib.rs b/user/test-workload/lib.rs
@@ -14,6 +14,7 @@
 #![deny(deprecated_in_future)]
 #![deny(keyword_idents)]
 #![deny(macro_use_extern_crate)]
+#![deny(missing_abi)]
 #![allow(unsafe_code)]
 #![deny(unused_crate_dependencies)]
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ var lints = []string{`
`32`	`32`	`"deprecated_in_future",`
`33`	`33`	`"keyword_idents",`
`34`	`34`	`"macro_use_extern_crate",`
	`35`	`+ "missing_abi",`
`35`	`36`	`"unused_crate_dependencies",`
`36`	`37`	`"unsafe_code",`
`37`	`38`	`}`