added additional exception to handle 404

Signed-off-by: Neil South <[email protected]>

Author: neildsouth

src/TaskManager/Plug-ins/Argo/ArgoClient.cs

@@ -20,6 +20,8 @@
 using Ardalis.GuardClauses;
 using Microsoft.Extensions.Logging;
 using Monai.Deploy.WorkflowManager.TaskManager.Argo.Logging;
+using System.Net;
+using Monai.Deploy.WorkflowManager.TaskManager.Argo.Exceptions;
 
 namespace Monai.Deploy.WorkflowManager.TaskManager.Argo
 {
@@ -78,7 +80,23 @@ public async Task<Workflow> Argo_StopWorkflowAsync(string argoNamespace, string
 
             const string method = "PUT";
             var content = new StringContent(Newtonsoft.Json.JsonConvert.SerializeObject(body));
-            return await SendRequest<Workflow>(content, urlBuilder, method, new CancellationToken()).ConfigureAwait(false);
+            try
+            {
+                return await SendRequest<Workflow>(content, urlBuilder, method, new CancellationToken()).ConfigureAwait(false);
+            }
+            catch (ApiException<Error> ex)
+            {
+                if (ex.StatusCode == (int)HttpStatusCode.NotFound)
+                {
+                    throw new ArgoWorkflowNotFoundException(body.Name, ex);
+                }
+                throw;
+            }
+            catch (Exception)
+            {
+                throw;
+            }
+
 
         }
 
@@ -93,7 +111,22 @@ public async Task<Workflow> Argo_TerminateWorkflowAsync(string argoNamespace, st
 
             const string method = "PUT";
             var content = new StringContent(Newtonsoft.Json.JsonConvert.SerializeObject(body));
-            return await SendRequest<Workflow>(content, urlBuilder, method, new CancellationToken()).ConfigureAwait(false);
+            try
+            {
+                return await SendRequest<Workflow>(content, urlBuilder, method, new CancellationToken()).ConfigureAwait(false);
+            }
+            catch (ApiException<Error> ex)
+            {
+                if (ex.StatusCode == (int)HttpStatusCode.NotFound)
+                {
+                    throw new ArgoWorkflowNotFoundException(body.Name, ex);
+                }
+                throw;
+            }
+            catch (Exception)
+            {
+                throw;
+            }
         }
 
         public async Task<WorkflowTemplate?> Argo_GetWorkflowTemplateAsync(string argoNamespace, string name, string? getOptionsResourceVersion)

src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs

@@ -30,6 +30,7 @@
 using Monai.Deploy.WorkflowManager.TaskManager.API.Models;
 using Monai.Deploy.WorkflowManager.TaskManager.Argo.Logging;
 using Newtonsoft.Json;
+using Monai.Deploy.WorkflowManager.TaskManager.Argo.Exceptions;
 
 [assembly: PlugIn()]
 namespace Monai.Deploy.WorkflowManager.TaskManager.Argo
@@ -916,10 +917,14 @@ public override async Task HandleTimeout(string identity)
                     Namespace = _namespace
                 });
             }
-            catch (Exception ex)
+            catch (ArgoWorkflowNotFoundException ex)
             {
                 _logger.ExecptionStoppingArgoWorkflow(identity, ex);
             }
+            catch (Exception)
+            {
+                throw;
+            }
         }
 
         public async Task<WorkflowTemplate> CreateArgoTemplate(string template)

src/TaskManager/Plug-ins/Argo/Exceptions/ArgoWorkflowNotFoundException.cs

@@ -0,0 +1,41 @@
+/*
+ * Copyright 2022 MONAI Consortium
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System.Runtime.Serialization;
+
+namespace Monai.Deploy.WorkflowManager.TaskManager.Argo.Exceptions
+{
+    [Serializable]
+    public class ArgoWorkflowNotFoundException : Exception
+    {
+        public ArgoWorkflowNotFoundException(string argoWorkflowName)
+            : base($"Argo workflow '{argoWorkflowName}' not found.")
+        {
+        }
+
+        public ArgoWorkflowNotFoundException(string? message, Exception? innerException) : base(message, innerException)
+        {
+        }
+
+        protected ArgoWorkflowNotFoundException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
+
+        public ArgoWorkflowNotFoundException()
+        {
+        }
+    }
+}

src/TaskManager/Plug-ins/Argo/ArtifactMappingNotFoundException.cs renamed to src/TaskManager/Plug-ins/Argo/Exceptions/ArtifactMappingNotFoundException.cs

@@ -16,7 +16,7 @@
 
 using System.Runtime.Serialization;
 
-namespace Monai.Deploy.WorkflowManager.TaskManager.Argo
+namespace Monai.Deploy.WorkflowManager.TaskManager.Argo.Exceptions
 {
     [Serializable]
     public class ArtifactMappingNotFoundException : Exception

src/TaskManager/Plug-ins/Argo/TemplateNotFoundException.cs renamed to src/TaskManager/Plug-ins/Argo/Exceptions/TemplateNotFoundException.cs

@@ -16,7 +16,7 @@
 
 using System.Runtime.Serialization;
 
-namespace Monai.Deploy.WorkflowManager.TaskManager.Argo
+namespace Monai.Deploy.WorkflowManager.TaskManager.Argo.Exceptions
 {
     [Serializable]
     public class TemplateNotFoundException : Exception