ac-909 (#652)

* ac-909

Signed-off-by: Lillie Dae <[email protected]>

Author: lillie-dae

src/WorkflowManager/WorkflowManager/Controllers/WorkflowsController.cs

@@ -156,7 +156,7 @@ public async Task<IActionResult> ValidateAsync([FromBody] WorkflowUpdateRequest
 
             if (errors.Count > 0)
             {
-                var validationErrors = string.Join(", ", errors);
+                var validationErrors = WorkflowValidator.ErrorsToString(errors);
                 _logger.LogDebug($"{nameof(CreateAsync)} - Failed to validate {nameof(workflow)}: {validationErrors}");
 
                 return Problem($"Failed to validate {nameof(workflow)}: {string.Join(", ", validationErrors)}", $"/workflows", BadRequest);
@@ -180,7 +180,7 @@ public async Task<IActionResult> CreateAsync([FromBody] Workflow workflow)
 
             if (errors.Count > 0)
             {
-                var validationErrors = string.Join(", ", errors);
+                var validationErrors = WorkflowValidator.ErrorsToString(errors);
                 _logger.LogDebug($"{nameof(CreateAsync)} - Failed to validate {nameof(workflow)}: {validationErrors}");
 
                 return Problem($"Failed to validate {nameof(workflow)}: {string.Join(", ", validationErrors)}", $"/workflows", BadRequest);
@@ -226,7 +226,7 @@ public async Task<IActionResult> UpdateAsync([FromBody] WorkflowUpdateRequest re
 
             if (errors.Count > 0)
             {
-                var validationErrors = string.Join(", ", errors);
+                var validationErrors = WorkflowValidator.ErrorsToString(errors);
                 _logger.LogDebug($"{nameof(UpdateAsync)} - Failed to validate {nameof(workflow)}: {validationErrors}");
 
                 return Problem($"Failed to validate {nameof(workflow)}: {string.Join(", ", validationErrors)}", $"/workflows/{id}", BadRequest);

src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs

@@ -35,7 +35,11 @@ namespace Monai.Deploy.WorkflowManager.Validators
     /// </summary>
     public class WorkflowValidator
     {
-        private const string Comma = "⸴ ";
+        /// <summary>
+        /// Separator when joining errors in single string.
+        /// </summary>
+        public static readonly string Separator = ";";
+        private const string Comma = ", ";
         private readonly ILogger<WorkflowValidator> _logger;
 
         /// <summary>
@@ -64,6 +68,16 @@ public WorkflowValidator(IWorkflowService workflowService, ILogger<WorkflowValid
         /// </summary>
         public string OrignalName { get; internal set; } = string.Empty;
 
+        /// <summary>
+        /// Returns single string of errors.
+        /// </summary>
+        /// <param name="errors">List of errors.</param>
+        /// <returns></returns>
+        public static string ErrorsToString(List<string> errors)
+        {
+            return string.Join(Separator, errors);
+        }
+
         /// <summary>
         /// Resets the validator.
         /// </summary>