Skip to content

Commit 0833d1d

Browse files
authored
Merge pull request #723 from Project-MONAI/AW-RevertClinicalReviewTaskModifications
Reverted changes for Workflow validation
2 parents 1a58c79 + e696eb1 commit 0833d1d

File tree

6 files changed

+1052
-1536
lines changed

6 files changed

+1052
-1536
lines changed

src/Shared/Shared/ValidationConstants.cs

-11
Original file line numberDiff line numberDiff line change
@@ -48,24 +48,13 @@ public static class ValidationConstants
4848
/// </summary>
4949
public static readonly string Mode = "mode";
5050

51-
/// <summary>
52-
/// Key for the notifications.
53-
/// </summary>
54-
public static readonly string Notifications = "notifications";
55-
5651
public enum ModeValues
5752
{
5853
QA,
5954
Research,
6055
Clinical
6156
}
6257

63-
public enum NotificationValues
64-
{
65-
True,
66-
False
67-
}
68-
6958
/// <summary>
7059
/// Required arguments to run the clinical review task workflow args.
7160
/// </summary>

src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs

-10
Original file line numberDiff line numberDiff line change
@@ -407,16 +407,6 @@ private void ValidateClinicalReviewRequiredFields(TaskObject[] tasks, TaskObject
407407
return;
408408
}
409409

410-
if (!currentTask.Args.ContainsKey(Notifications))
411-
{
412-
Errors.Add($"Task: '{currentTask.Id}' notifications must be specified.");
413-
return;
414-
}
415-
else if (!Enum.TryParse(typeof(NotificationValues), currentTask.Args[Notifications], true, out var _))
416-
{
417-
Errors.Add($"Task: '{currentTask.Id}' notifications is incorrectly specified{Comma}please specify 'true' or 'false'");
418-
}
419-
420410
var reviewedTask = tasks.First(t => t.Id.ToLower() == currentTask.Args[ReviewedTaskId].ToLower());
421411

422412
if (reviewedTask.Type.Equals(ArgoTaskType, StringComparison.OrdinalIgnoreCase) is false)

0 commit comments

Comments
 (0)