Skip to content

Commit fc11044

Browse files
authored
Support VS2019 vc142/vc141_xp and build customization #385
1 parent f76f539 commit fc11044

File tree

6 files changed

+15
-3
lines changed

6 files changed

+15
-3
lines changed

Notepad2e.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,10 @@
6767
<PropertyGroup Label="Configuration">
6868
<ConfigurationType>Application</ConfigurationType>
6969
<CharacterSet>Unicode</CharacterSet>
70-
<PlatformToolset Condition="'$(VisualStudioVersion)' == '15.0'">v141_xp</PlatformToolset>
70+
<PlatformToolset Condition="'$(VisualStudioVersion)' != '14.0'">v141_xp</PlatformToolset>
7171
<PlatformToolset Condition="'$(VisualStudioVersion)' == '14.0'">v140_xp</PlatformToolset>
7272
</PropertyGroup>
73+
<Import Project="User.props" Condition="exists('User.props')" />
7374
<PropertyGroup Condition="'$(Configuration)'=='Debug'" Label="Configuration">
7475
<UseDebugLibraries>true</UseDebugLibraries>
7576
</PropertyGroup>

User.props.IN

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!-- NOTE: You can copy this file to User.props to override some standard settings -->
3+
<!-- NOTE: Don't add the copy User.props to source control!!! -->
4+
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
5+
<PropertyGroup Label="Configuration">
6+
<PlatformToolset>v142</PlatformToolset> <!-- VS2019 -->
7+
</PropertyGroup>
8+
</Project>

scintilla/boostregex/BoostRegExSearch.cxx

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <stdlib.h>
1111
#include <iterator>
1212
#include <memory>
13+
#include <stdexcept>
1314
#include <vector>
1415
#include "scintilla.h"
1516
#include "Platform.h"

scintilla/boostregex/UTF8DocumentIterator.h

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
#include <iterator>
44
#include <memory>
5+
#include <stdexcept>
56
#include <vector>
67
#include "Platform.h"
78
#include "SplitVector.h"

scintilla/win32/PlatWin.cxx

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include <map>
1919
#include <algorithm>
2020
#include <memory>
21+
#include <string>
2122

2223
#pragma comment(lib, "Msimg32.lib")
2324

test/Extension/Notepad2eTests.vcxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
<ProjectGuid>{A3852498-51BF-4A24-B720-F69D2E5E6403}</ProjectGuid>
2323
<Keyword>Win32Proj</Keyword>
2424
<RootNamespace>Notepad2eTests</RootNamespace>
25-
<WindowsTargetPlatformVersion>7.0</WindowsTargetPlatformVersion>
2625
</PropertyGroup>
2726
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2827
<PropertyGroup Label="Configuration">
2928
<ConfigurationType>DynamicLibrary</ConfigurationType>
30-
<PlatformToolset Condition="'$(VisualStudioVersion)' == '15.0'">v141_xp</PlatformToolset>
29+
<PlatformToolset Condition="'$(VisualStudioVersion)' != '14.0'">v141_xp</PlatformToolset>
3130
<PlatformToolset Condition="'$(VisualStudioVersion)' == '14.0'">v140_xp</PlatformToolset>
3231
<CharacterSet>Unicode</CharacterSet>
3332
<UseOfMfc>false</UseOfMfc>
3433
</PropertyGroup>
34+
<Import Project="..\..\User.props" Condition="exists('..\..\User.props')" />
3535
<PropertyGroup Condition="'$(Configuration)'=='Debug'" Label="Configuration">
3636
<UseDebugLibraries>true</UseDebugLibraries>
3737
</PropertyGroup>

0 commit comments

Comments
 (0)