Skip to content

Commit 7448021

Browse files
authored
Merge pull request #419 from PrefectHQ/vue-3-3
Remove some 3.3. shims
2 parents 48fb335 + 7ea01b6 commit 7448021

File tree

15 files changed

+17
-41
lines changed

15 files changed

+17
-41
lines changed

src/types/maybe.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { Ref, UnwrapRef } from 'vue'
1+
import { UnwrapRef } from 'vue'
22

33
export type MaybePromise<T = unknown> = T | Promise<T>
4-
export type MaybeRef<T = unknown> = T | Ref<T>
54
export type MaybeUnwrapRef<T = unknown> = T | UnwrapRef<T>
6-
export type MaybeRefOrGetter<T = unknown> = MaybeRef<T> | (() => T)
75
export type MaybeArray<T = unknown> = T | T[]

src/useBoolean/useBoolean.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { ref, Ref } from 'vue'
2-
import { MaybeRef } from '@/types/maybe'
1+
import { ref, Ref, MaybeRef } from 'vue'
32

43
type UseBoolean = {
54
value: Ref<boolean>,

src/useClickOutside/useClickOutside.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { onScopeDispose } from 'vue'
2-
import { MaybeRefOrGetter } from '@/types/maybe'
1+
import { MaybeRefOrGetter, onScopeDispose, toValue } from 'vue'
32
import { useGlobalEventListener } from '@/useGlobalEventListener'
4-
import { toValue } from '@/utilities/vue'
53

64
type ClickOutsideEntry = {
75
element: MaybeRefOrGetter<Element>,

src/useEventListener/useEventListener.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { ref, watch } from 'vue'
2-
import { MaybeRefOrGetter } from '@/types/maybe'
1+
import { ref, watch, toValue, MaybeRefOrGetter } from 'vue'
32
import { tryOnScopeDispose } from '@/utilities/tryOnScopeDispose'
4-
import { toValue } from '@/utilities/vue'
53

64
export type UseEventListener = {
75
add: () => void,

src/useIntersectionObserver/useIntersectionObserver.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import { onMounted, onUnmounted, ref, Ref, unref, watch } from 'vue'
2-
import { MaybeRef, MaybeRefOrGetter } from '@/types/maybe'
3-
import { toValue } from '@/utilities/vue'
1+
import { onMounted, onUnmounted, ref, Ref, unref, watch, toValue, MaybeRef, MaybeRefOrGetter } from 'vue'
42

53
export type UseIntersectionObserverResponse = {
64
observe: (element: MaybeRefOrGetter<HTMLElement | undefined>) => void,

src/useIsSame/useIsSame.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { computed, ComputedRef, ref } from 'vue'
2-
import { MaybeRef } from '@/types/maybe'
1+
import { computed, ComputedRef, ref, MaybeRef } from 'vue'
32
import { isSame } from '@/utilities/isSame'
43

54
export function useIsSame(valueA: MaybeRef, valueB: MaybeRef): ComputedRef<boolean> {

src/useKeyDown/useKeyDown.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { ComputedRef, computed, reactive, unref } from 'vue'
2-
import { MaybeArray, MaybeRef } from '@/types/maybe'
1+
import { ComputedRef, computed, reactive, unref, MaybeRef } from 'vue'
2+
import { MaybeArray } from '@/types/maybe'
33
import { asArray } from '@/utilities/arrays'
44
import { tryOnScopeDispose } from '@/utilities/tryOnScopeDispose'
55

src/useNow/useNow.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { ref, Ref } from 'vue'
2-
import { MaybeRef } from '@/types/maybe'
1+
import { ref, Ref, MaybeRef } from 'vue'
32
import { tryOnScopeDispose } from '@/utilities/tryOnScopeDispose'
43

54
export type UseNow = {

src/usePositionStickyObserver/usePositionStickyObserver.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { Ref, computed, ref, watch } from 'vue'
2-
import { MaybeRefOrGetter } from '@/types/maybe'
1+
import { Ref, computed, ref, watch, toRef, toValue, MaybeRefOrGetter } from 'vue'
32
import { useIntersectionObserver } from '@/useIntersectionObserver'
4-
import { toValue } from '@/utilities/vue'
53

64
export type UsePositionStickyObserverResponse = {
75
stuck: Ref<boolean>,
@@ -21,7 +19,7 @@ export function usePositionStickyObserver(
2119
element: MaybeRefOrGetter<HTMLElement | undefined>,
2220
options?: MaybeRefOrGetter<UsePositionStickyObserverOptions>,
2321
): UsePositionStickyObserverResponse {
24-
const elementRef = computed(() => toValue(element))
22+
const elementRef = toRef(element)
2523
const stuck = ref(false)
2624

2725
const observerOptions = computed(() => {

src/useScrollLinking/useScrollLinking.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { onMounted, onUnmounted, ref, Ref } from 'vue'
2-
import { MaybeRef } from '@/types/maybe'
1+
import { onMounted, onUnmounted, ref, Ref, MaybeRef } from 'vue'
32

43
type DisconnectScrollLink = () => void
54
type UseScrollLinking = {

0 commit comments

Comments
 (0)