From 2a104e8115ca8ab0103292efd22573bafc148f85 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Mon, 4 Dec 2023 16:57:39 -0800 Subject: [PATCH] clang-tidy: use make functions Found with modernize-make-* Signed-off-by: Rosen Penev --- modules/bindbackend/binddnssec.cc | 2 +- modules/ldapbackend/powerldap.cc | 2 +- pdns/dynloader.cc | 4 ++-- pdns/saxfr.cc | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/bindbackend/binddnssec.cc b/modules/bindbackend/binddnssec.cc index 1cbeee24760e..191e22d10ab7 100644 --- a/modules/bindbackend/binddnssec.cc +++ b/modules/bindbackend/binddnssec.cc @@ -146,7 +146,7 @@ void Bind2Backend::setupDNSSEC() if (getArg("dnssec-db").empty() || d_hybrid) return; try { - d_dnssecdb = shared_ptr(new SSQLite3(getArg("dnssec-db"), getArg("dnssec-db-journal-mode"))); + d_dnssecdb = std::make_shared(getArg("dnssec-db"), getArg("dnssec-db-journal-mode")); setupStatements(); } catch (SSqlException& se) { diff --git a/modules/ldapbackend/powerldap.cc b/modules/ldapbackend/powerldap.cc index 75a82461db7a..fe5ce7f1bb00 100644 --- a/modules/ldapbackend/powerldap.cc +++ b/modules/ldapbackend/powerldap.cc @@ -287,7 +287,7 @@ PowerLDAP::SearchResult::Ptr PowerLDAP::search(const string& base, int scope, co throw LDAPException("Starting LDAP search: " + getError(rc)); } - return SearchResult::Ptr(new SearchResult(msgid, d_ld)); + return std::make_unique(msgid, d_ld); } /** diff --git a/pdns/dynloader.cc b/pdns/dynloader.cc index 9b8ba89ca798..64619d473b6d 100644 --- a/pdns/dynloader.cc +++ b/pdns/dynloader.cc @@ -110,7 +110,7 @@ int main(int argc, char **argv) string command = commands[0]; shared_ptr D; if(::arg()["remote-address"].empty()) - D=shared_ptr(new DynMessenger(socketname)); + D = std::make_shared(socketname); else { uint16_t port; try { @@ -121,7 +121,7 @@ int main(int argc, char **argv) exit(99); } - D=shared_ptr(new DynMessenger(ComboAddress(::arg()["remote-address"], port), ::arg()["secret"])); + D = std::make_shared(ComboAddress(::arg()["remote-address"], port), ::arg()["secret"]); } string message; diff --git a/pdns/saxfr.cc b/pdns/saxfr.cc index f6d25cfbc660..bd333095e955 100644 --- a/pdns/saxfr.cc +++ b/pdns/saxfr.cc @@ -129,7 +129,7 @@ try throw PDNSException("tcp read failed"); len=ntohs(len); - std::unique_ptr creply(new char[len]); + auto creply = std::make_unique(len); int n=0; int numread; while(n