Skip to content

Commit b4d71e2

Browse files
authored
fix(b2b2c): render_query endpoint cors restrictions (#40094)
1 parent 2028ccf commit b4d71e2

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

posthog/api/test/test_render_query.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ def test_render_query_page_renders_template(self, mock_render_template, mock_get
1414

1515
assert response.status_code == 200
1616
assert "X-Frame-Options" not in response.headers
17+
assert "frame-ancestors https: http:" in response.headers.get("Content-Security-Policy-Report-Only", "")
1718

1819
mock_render_template.assert_called_once()
1920
template_name, request = mock_render_template.call_args[0][:2]

posthog/middleware.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -720,6 +720,13 @@ def __call__(self, request):
720720
resource_url = "https://*.dev.posthog.dev"
721721

722722
connect_debug_url = "ws://localhost:8234" if settings.DEBUG or settings.TEST else ""
723+
frame_ancestors = "frame-ancestors https://posthog.com https://preview.posthog.com"
724+
if request.path.startswith("/render_query"):
725+
if settings.DEBUG or settings.TEST:
726+
frame_ancestors = "frame-ancestors https: http:"
727+
else:
728+
frame_ancestors = "frame-ancestors https:"
729+
723730
csp_parts = [
724731
"default-src 'self'",
725732
f"style-src 'self' 'unsafe-inline' {resource_url} https://fonts.googleapis.com",
@@ -729,7 +736,7 @@ def __call__(self, request):
729736
"child-src 'none'",
730737
"object-src 'none'",
731738
f"img-src 'self' data: {resource_url} https://posthog.com https://www.gravatar.com https://res.cloudinary.com https://platform.slack-edge.com",
732-
"frame-ancestors https://posthog.com https://preview.posthog.com",
739+
frame_ancestors,
733740
f"connect-src 'self' https://status.posthog.com {resource_url} {connect_debug_url} https://raw.githubusercontent.com https://api.github.com",
734741
# allow all sites for displaying heatmaps
735742
"frame-src https:",

0 commit comments

Comments
 (0)