Skip to content

Commit 64f6494

Browse files
haackedhaacked
committed
Remove all usages of is_simple_flag
It's not in use.
1 parent 0739b61 commit 64f6494

File tree

2 files changed

+2
-45
lines changed

2 files changed

+2
-45
lines changed

‎tests/UnitTests/Features/FeatureFlagsTests.cs‎

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public async Task ReturnsTrueWhenFeatureFlagIsEnabled(bool active, string rollou
2929
"id":1,
3030
"name":"Beta Feature",
3131
"key":"beta-feature",
32-
"is_simple_flag":true,
3332
"active":{{active.ToString().ToLowerInvariant()}},
3433
"rollout_percentage":100,
3534
"filters":{
@@ -486,7 +485,6 @@ public async Task MatchesOnPersonProperties()
486485
"id":1,
487486
"name":"Beta Feature",
488487
"key":"person-flag",
489-
"is_simple_flag":true,
490488
"active":true,
491489
"filters":{
492490
"groups":[
@@ -642,7 +640,6 @@ public async Task MatchesOnGroupProperties()
642640
"id":1,
643641
"name":"Beta Feature",
644642
"key":"group-flag",
645-
"is_simple_flag":true,
646643
"active":true,
647644
"filters":{
648645
"aggregation_group_type_index":0,
@@ -769,7 +766,6 @@ public async Task MatchesOnGroupProperties()
769766
"id":1,
770767
"name":"Beta Feature",
771768
"key":"group-flag",
772-
"is_simple_flag":true,
773769
"active":true,
774770
"filters":{
775771
"aggregation_group_type_index":0,
@@ -833,7 +829,6 @@ public async Task ReturnsCorrectValueForComplexFlags()
833829
"id": 1,
834830
"name": "Beta Feature",
835831
"key": "complex-flag",
836-
"is_simple_flag": false,
837832
"active": true,
838833
"filters": {
839834
"groups": [
@@ -990,7 +985,6 @@ public async Task CanFallbackToDecide()
990985
"id":1,
991986
"name":"Beta Feature",
992987
"key":"beta-feature",
993-
"is_simple_flag":true,
994988
"active":true,
995989
"filters":{
996990
"groups":[
@@ -1012,7 +1006,6 @@ public async Task CanFallbackToDecide()
10121006
"id":2,
10131007
"name":"Beta Feature",
10141008
"key":"beta-feature2",
1015-
"is_simple_flag":false,
10161009
"active":true,
10171010
"filters":{
10181011
"groups":[
@@ -1069,7 +1062,6 @@ public async Task DoesNotFallbackToDecideWhenOnlyEvaluateLocallyIsTrue()
10691062
"id":1,
10701063
"name":"Beta Feature",
10711064
"key":"beta-feature",
1072-
"is_simple_flag":true,
10731065
"active":true,
10741066
"filters":{
10751067
"groups":[
@@ -1091,7 +1083,6 @@ public async Task DoesNotFallbackToDecideWhenOnlyEvaluateLocallyIsTrue()
10911083
"id":2,
10921084
"name":"Beta Feature",
10931085
"key":"beta-feature2",
1094-
"is_simple_flag":false,
10951086
"active":true,
10961087
"filters":{
10971088
"groups":[
@@ -1160,7 +1151,6 @@ public async Task DoesNotCallDecideWhenCanBeEvaluatedLocally()
11601151
"id": 1,
11611152
"name": "Beta Feature",
11621153
"key": "beta-feature",
1163-
"is_simple_flag": false,
11641154
"active": true,
11651155
"rollout_percentage": 100,
11661156
"filters": {
@@ -1211,7 +1201,6 @@ public async Task NeverReturnsNullDuringRegularEvaluation()
12111201
"id": 1,
12121202
"name": "Beta Feature",
12131203
"key": "beta-feature",
1214-
"is_simple_flag": true,
12151204
"active": true,
12161205
"filters": {
12171206
"groups": [
@@ -1274,7 +1263,6 @@ public async Task ExperienceContinuityFlagNotEvaluatedLocally()
12741263
"id": 1,
12751264
"name": "Beta Feature",
12761265
"key": "beta-feature",
1277-
"is_simple_flag": false,
12781266
"active": true,
12791267
"rollout_percentage": 100,
12801268
"filters": {
@@ -1310,7 +1298,6 @@ public async Task LocalEvaluationWithNullValues()
13101298
"id":1,
13111299
"name":"Beta Feature",
13121300
"key":"beta-feature",
1313-
"is_simple_flag":true,
13141301
"active":true,
13151302
"filters":{
13161303
"groups":[
@@ -1397,7 +1384,6 @@ public async Task LocalEvaluationForCohorts()
13971384
"id":2,
13981385
"name":"Beta Feature",
13991386
"key":"beta-feature",
1400-
"is_simple_flag":false,
14011387
"active":true,
14021388
"filters":{
14031389
"groups":[
@@ -1509,7 +1495,6 @@ public async Task LocalEvaluationForNegatedCohorts()
15091495
"id":2,
15101496
"name":"Beta Feature",
15111497
"key":"beta-feature",
1512-
"is_simple_flag":false,
15131498
"active":true,
15141499
"filters":{
15151500
"groups":[
@@ -1644,7 +1629,6 @@ public async Task ReturnsFlag()
16441629
"id":1,
16451630
"name":"Beta Feature",
16461631
"key":"beta-feature",
1647-
"is_simple_flag":false,
16481632
"active":true,
16491633
"rollout_percentage":100,
16501634
"filters":{
@@ -1689,7 +1673,6 @@ public async Task GetsFlagWithVariantOverrides()
16891673
"id":1,
16901674
"name":"Beta Feature",
16911675
"key":"beta-feature",
1692-
"is_simple_flag":false,
16931676
"active":true,
16941677
"rollout_percentage":100,
16951678
"filters":{
@@ -1763,7 +1746,6 @@ public async Task GetsFlagWithClashingVariantOverrides()
17631746
"id":1,
17641747
"name":"Beta Feature",
17651748
"key":"beta-feature",
1766-
"is_simple_flag":false,
17671749
"active":true,
17681750
"rollout_percentage":100,
17691751
"filters":{
@@ -1856,7 +1838,6 @@ public async Task GetsFlagWithInvalidVariantOverrides()
18561838
"id":1,
18571839
"name":"Beta Feature",
18581840
"key":"beta-feature",
1859-
"is_simple_flag":false,
18601841
"active":true,
18611842
"rollout_percentage":100,
18621843
"filters":{
@@ -1930,7 +1911,6 @@ public async Task GetsFlagWithMultipleVariantOverrides()
19301911
"id":1,
19311912
"name":"Beta Feature",
19321913
"key":"beta-feature",
1933-
"is_simple_flag":false,
19341914
"active":true,
19351915
"rollout_percentage":100,
19361916
"filters":{
@@ -2011,7 +1991,6 @@ public async Task BooleanFeatureFlagPayloadsLocal()
20111991
"id":1,
20121992
"name":"Beta Feature",
20131993
"key":"person-flag",
2014-
"is_simple_flag":true,
20151994
"active":true,
20161995
"filters":{
20171996
"groups":[
@@ -2077,7 +2056,6 @@ public async Task MultivariateFeatureFlagPayloads()
20772056
"id":1,
20782057
"name":"Beta Feature",
20792058
"key":"beta-feature",
2080-
"is_simple_flag":false,
20812059
"active":true,
20822060
"rollout_percentage":100,
20832061
"filters":{
@@ -2501,7 +2479,6 @@ public async Task RetrievesAllFlagsWithFallback()
25012479
"id":1,
25022480
"name":"Beta Feature",
25032481
"key":"beta-feature",
2504-
"is_simple_flag":false,
25052482
"active":true,
25062483
"rollout_percentage":100,
25072484
"filters":{
@@ -2517,7 +2494,6 @@ public async Task RetrievesAllFlagsWithFallback()
25172494
"id":2,
25182495
"name":"Beta Feature",
25192496
"key":"disabled-feature",
2520-
"is_simple_flag":false,
25212497
"active":true,
25222498
"filters":{
25232499
"groups":[
@@ -2532,7 +2508,6 @@ public async Task RetrievesAllFlagsWithFallback()
25322508
"id":3,
25332509
"name":"Beta Feature",
25342510
"key":"beta-feature2",
2535-
"is_simple_flag":false,
25362511
"active":true,
25372512
"filters":{
25382513
"groups":[
@@ -2591,7 +2566,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallback()
25912566
"id":1,
25922567
"name":"Beta Feature",
25932568
"key":"beta-feature",
2594-
"is_simple_flag":false,
25952569
"active":true,
25962570
"rollout_percentage":100,
25972571
"filters":{
@@ -2612,7 +2586,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallback()
26122586
"id":2,
26132587
"name":"Beta Feature",
26142588
"key":"disabled-feature",
2615-
"is_simple_flag":false,
26162589
"active":true,
26172590
"filters":{
26182591
"groups":[
@@ -2632,7 +2605,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallback()
26322605
"id":3,
26332606
"name":"Beta Feature",
26342607
"key":"beta-feature2",
2635-
"is_simple_flag":false,
26362608
"active":true,
26372609
"filters":{
26382610
"groups":[
@@ -2738,7 +2710,6 @@ public async Task RetrievesAllFlagsWithNoFallback()
27382710
"id":1,
27392711
"name":"Beta Feature",
27402712
"key":"beta-feature",
2741-
"is_simple_flag":false,
27422713
"active":true,
27432714
"rollout_percentage":100,
27442715
"filters":{
@@ -2754,7 +2725,6 @@ public async Task RetrievesAllFlagsWithNoFallback()
27542725
"id":2,
27552726
"name":"Beta Feature",
27562727
"key":"disabled-feature",
2757-
"is_simple_flag":false,
27582728
"active":true,
27592729
"filters":{
27602730
"groups":[
@@ -2792,7 +2762,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithNoFallback()
27922762
"id":1,
27932763
"name":"Beta Feature",
27942764
"key":"beta-feature",
2795-
"is_simple_flag":false,
27962765
"active":true,
27972766
"rollout_percentage":100,
27982767
"filters":{
@@ -2813,7 +2782,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithNoFallback()
28132782
"id":2,
28142783
"name":"Beta Feature",
28152784
"key":"disabled-feature",
2816-
"is_simple_flag":false,
28172785
"active":true,
28182786
"filters":{
28192787
"groups":[
@@ -2866,7 +2834,6 @@ public async Task RetrievesAllFlagsWithFallbackButOnlyLocalEvaluationSet()
28662834
"id":1,
28672835
"name":"Beta Feature",
28682836
"key":"beta-feature",
2869-
"is_simple_flag":false,
28702837
"active":true,
28712838
"rollout_percentage":100,
28722839
"filters":{
@@ -2882,7 +2849,6 @@ public async Task RetrievesAllFlagsWithFallbackButOnlyLocalEvaluationSet()
28822849
"id":2,
28832850
"name":"Beta Feature",
28842851
"key":"disabled-feature",
2885-
"is_simple_flag":false,
28862852
"active":true,
28872853
"filters":{
28882854
"groups":[
@@ -2897,7 +2863,6 @@ public async Task RetrievesAllFlagsWithFallbackButOnlyLocalEvaluationSet()
28972863
"id":3,
28982864
"name":"Beta Feature",
28992865
"key":"beta-feature2",
2900-
"is_simple_flag":false,
29012866
"active":true,
29022867
"filters":{
29032868
"groups":[
@@ -2953,7 +2918,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallbackButOnlyLocalEvaluation
29532918
"id":1,
29542919
"name":"Beta Feature",
29552920
"key":"beta-feature",
2956-
"is_simple_flag":false,
29572921
"active":true,
29582922
"rollout_percentage":100,
29592923
"filters":{
@@ -2972,7 +2936,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallbackButOnlyLocalEvaluation
29722936
"id":2,
29732937
"name":"Beta Feature",
29742938
"key":"disabled-feature",
2975-
"is_simple_flag":false,
29762939
"active":true,
29772940
"filters":{
29782941
"groups":[
@@ -2990,7 +2953,6 @@ public async Task RetrievesAllFlagsAndPayloadsWithFallbackButOnlyLocalEvaluation
29902953
"id":3,
29912954
"name":"Beta Feature",
29922955
"key":"beta-feature2",
2993-
"is_simple_flag":false,
29942956
"active":true,
29952957
"filters":{
29962958
"groups":[
@@ -3041,7 +3003,6 @@ public async Task ComputesInactiveFlagsLocally()
30413003
"id":1,
30423004
"name":"Beta Feature",
30433005
"key":"beta-feature",
3044-
"is_simple_flag":false,
30453006
"active":true,
30463007
"rollout_percentage":100,
30473008
"filters":{
@@ -3059,7 +3020,6 @@ public async Task ComputesInactiveFlagsLocally()
30593020
"id":2,
30603021
"name":"Beta Feature",
30613022
"key":"disabled-feature",
3062-
"is_simple_flag":false,
30633023
"active":true,
30643024
"filters":{
30653025
"groups":[
@@ -3093,8 +3053,7 @@ public async Task ComputesInactiveFlagsLocally()
30933053
"id":1,
30943054
"name":"Beta Feature",
30953055
"key":"beta-feature",
3096-
"is_simple_flag":false,
3097-
"active":false,
3056+
"active":false,
30983057
"rollout_percentage":100,
30993058
"filters":{
31003059
"groups":[
@@ -3111,8 +3070,7 @@ public async Task ComputesInactiveFlagsLocally()
31113070
"id":2,
31123071
"name":"Beta Feature",
31133072
"key":"disabled-feature",
3114-
"is_simple_flag":false,
3115-
"active":true,
3073+
"active":true,
31163074
"filters":{
31173075
"groups":[
31183076
{

‎tests/UnitTests/PostHogClientTests.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@ public async Task UsesAuthenticatedHttpClientForLocalEvaluationFlags()
324324
"id":1,
325325
"name":"Beta Feature",
326326
"key":"beta-feature",
327-
"is_simple_flag":false,
328327
"active":true,
329328
"rollout_percentage":100,
330329
"filters":{

0 commit comments

Comments
 (0)