Fail authentication when browser state is older than 14 days#37
Open
chewinggum604-art wants to merge 1 commit into
Open
Fail authentication when browser state is older than 14 days#37chewinggum604-art wants to merge 1 commit into
chewinggum604-art wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today,
AuthManager.is_authenticated()only soft-warns when the browserstate file is older than 7 days but still returns
True. If the cookies haveactually expired, the next
ask_questioncall ends up timing out at theNotebookLM URL wait — without a clear hint that re-auth is what's needed.
This PR adds a hard cutoff at 14 days. Past that,
is_authenticated()returns
Falseand prints the exact command to recover.Behavior
True(no change).The thresholds live as class constants
STALE_WARN_DAYSandSTALE_FAIL_DAYSonAuthManager, so they're easy to tune.Why 14 days?
Google session cookies typically survive 2 weeks of inactivity in my
testing. 14 is conservative enough that we don't fail valid sessions, but
catches the dead-cookie case before downstream timeouts hit. Open to
discussion.
Diff