reduncant casts

Author: CamDavidsonPilon

core/pioreactor/background_jobs/od_reading.py

@@ -687,7 +687,7 @@ def pop_reference_reading(self, raw_readings: RawPDReadings) -> tuple[pt.Voltage
         return ref_reading, raw_readings
 
     def transform(self, pd_reading: pt.Voltage) -> pt.OD:
-        return cast(pt.OD, pd_reading)
+        return pd_reading
 
 
 class PhotodiodeIrLedReferenceTrackerStaticInit(IrLedReferenceTracker):

core/pioreactor/calibrations/protocols/od_fusion_standards.py

@@ -68,7 +68,7 @@ def _channel_angle_map_from_config() -> dict[pt.PdChannel, pt.PdAngle]:
 def _aggregate_angles(readings: structs.ODReadings) -> dict[pt.PdAngle, float]:
     by_angle: dict[pt.PdAngle, list[float]] = {}
     for reading in readings.ods.values():
-        angle = cast(pt.PdAngle, reading.angle)
+        angle = reading.angle
         if angle not in FUSION_ANGLES:
             continue
         by_angle.setdefault(angle, []).append(float(reading.od))

core/pioreactor/calibrations/protocols/od_standards.py

@@ -615,12 +615,15 @@ def get_valid_od_devices_for_this_unit() -> list[pt.ODCalibrationDevices]:
     for _, angle in pd_channels.items():
         if angle in (None, "", REF_keyword):
             continue
-        device = f"od{angle}"
-        if device in pt.OD_DEVICES and device not in valid_devices:
-            valid_devices.append(cast(pt.ODCalibrationDevices, device))
+        if angle == "45" and "od45" not in valid_devices:
+            valid_devices.append("od45")
+        elif angle == "90" and "od90" not in valid_devices:
+            valid_devices.append("od90")
+        elif angle == "135" and "od135" not in valid_devices:
+            valid_devices.append("od135")
 
     if len(valid_devices) >= 2:
-        valid_devices.append(cast(pt.ODCalibrationDevices, "od"))
+        valid_devices.append("od")
 
     return valid_devices
 

core/pioreactor/hardware.py

@@ -132,7 +132,9 @@ def get_layered_mod_config_for_model(mod: str, model_name: str, model_version: s
 def determine_gpiochip() -> pt.GpioChip:
     """Return the GPIO chip index for the current Raspberry Pi."""
 
-    return cast(pt.GpioChip, 4 if rpi_version_info.startswith("Raspberry Pi 5") else 0)
+    if rpi_version_info.startswith("Raspberry Pi 5"):
+        return 4
+    return 0
 
 
 @cache

core/pioreactor/structs.py

@@ -490,10 +490,10 @@ class SimplePeristalticPumpCalibration(CalibrationBase, kw_only=True, tag="simpl
     y: str = "Volume"
 
     def ml_to_duration(self, ml: pt.mL) -> pt.Seconds:
-        return t.cast(pt.Seconds, self.y_to_x(ml))
+        return self.y_to_x(ml)
 
     def duration_to_ml(self, duration: pt.Seconds) -> pt.mL:
-        return t.cast(pt.mL, self.x_to_y(duration))
+        return self.x_to_y(duration)
 
 
 class SimpleStirringCalibration(CalibrationBase, kw_only=True, tag="simple_stirring"):

core/pioreactor/web/unit_api.py

@@ -27,7 +27,6 @@
 from msgspec import to_builtins
 from msgspec.yaml import decode as yaml_decode
 from pioreactor import structs
-from pioreactor import types as pt
 from pioreactor import whoami
 from pioreactor.bioreactor import get_all_bioreactor_values
 from pioreactor.bioreactor import get_bioreactor_value
@@ -37,7 +36,6 @@
 from pioreactor.config import get_leader_hostname
 from pioreactor.estimators import ESTIMATOR_PATH
 from pioreactor.models import get_registered_models
-from pioreactor.pubsub import Client
 from pioreactor.pubsub import create_client
 from pioreactor.structs import CalibrationBase
 from pioreactor.structs import subclass_union
@@ -787,9 +785,7 @@ def update_bioreactor_values(experiment: str) -> ResponseReturnValue:
     try:
         with create_client() as mqtt_client:
             for variable_name, value in values.items():
-                set_and_publish_bioreactor_value(
-                    cast(Client, mqtt_client), HOSTNAME, experiment, variable_name, value
-                )
+                set_and_publish_bioreactor_value(mqtt_client, HOSTNAME, experiment, variable_name, value)
     except Exception as e:
         publish_to_error_log(str(e), "update_bioreactor_values")
         abort_with(400, str(e))