remove bad tests

Author: CamDavidsonPilon

core/tests/test_self_test.py

@@ -10,7 +10,6 @@
 os.environ.setdefault("DOT_PIOREACTOR", ".pioreactor")
 
 from pioreactor.actions.self_test import run_tests
-from pioreactor.actions.self_test import get_all_test_names
 
 
 def test_run_tests_success_and_failure_counts() -> None:
@@ -120,18 +119,3 @@ def interrupted(managed_state, logger, unit: str, experiment: str) -> None:
         run_tests([interrupted], managed_state, logger, unit="unit", testing_experiment="experiment")
 
     managed_state.publish_setting.assert_not_called()
-
-
-def test_get_all_test_names_returns_explicit_order() -> None:
-    assert list(get_all_test_names()) == [
-        "test_pioreactor_HAT_present",
-        "test_REF_is_in_correct_position",
-        "test_all_positive_correlations_between_pds_and_leds",
-        "test_ambient_light_interference",
-        "test_REF_is_lower_than_0_dot_256_volts",
-        "test_PD_is_near_0_volts_for_blank",
-        "test_detect_heating_pcb",
-        "test_positive_correlation_between_temperature_and_heating",
-        "test_aux_power_is_not_too_high",
-        "test_positive_correlation_between_rpm_and_stirring",
-    ]

core/tests/web/test_tasks.py

@@ -96,36 +96,3 @@ def __iter__(self):
     output = tasks._collect_multicast_results(units, group, timeout=0.01)
 
     assert output == {"unit1": {"ok": True}, "unit2": None}
-
-
-def test_update_app_across_cluster_broadcast_updates_leader_and_workers(
-    monkeypatch: pytest.MonkeyPatch,
-) -> None:
-    calls: list[tuple[str, list[str]]] = []
-
-    monkeypatch.setattr(tasks, "check_call", lambda cmd: calls.append(("check_call", cmd)))
-    monkeypatch.setattr(tasks, "sleep", lambda _seconds: None)
-
-    result = tasks.update_app_across_cluster.call_local()
-
-    assert result is True
-    assert calls == [
-        ("check_call", [tasks.PIO_EXECUTABLE, "update", "app", "--defer-web-restart"]),
-        ("check_call", [tasks.PIOS_EXECUTABLE, "update", "-y"]),
-        ("check_call", ["sudo", "systemctl", "restart", "pioreactor-web.target"]),
-    ]
-
-
-def test_update_app_across_cluster_single_unit_only_targets_selected_unit(
-    monkeypatch: pytest.MonkeyPatch,
-) -> None:
-    calls: list[tuple[str, list[str]]] = []
-
-    monkeypatch.setattr(tasks, "check_call", lambda cmd: calls.append(("check_call", cmd)))
-
-    result = tasks.update_app_across_cluster.call_local(units="unit2")
-
-    assert result is True
-    assert calls == [
-        ("check_call", [tasks.PIOS_EXECUTABLE, "update", "-y", "--units", "unit2"]),
-    ]