fix button press bug, order in self-test

CamDavidsonPilon · CamDavidsonPilon · commit 11c339a67dd3 · 2026-03-02T13:34:19.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+### Upcoming
+
+#### Bug fixes
+
+ - Fixed a UI crash when MQTT `button_down` events triggered tactile-button notifications: custom snackbar content now renders with a ref-able root element so notistack transitions no longer throw `Custom snackbar is not refForwarding`.
+ - Fix plugins not being loaded correctly in the background task worker. This affected mostly plgin calibrations.
+
 ### 26.2.26
 
 #### Bug fixes
diff --git a/core/pioreactor/actions/self_test.py b/core/pioreactor/actions/self_test.py
@@ -55,6 +55,19 @@
 
 
 SELF_TEST_TIMEOUT_SECONDS = 180.0
+ORDERED_SELF_TEST_NAMES: tuple[str, ...] = (
+    # order in UI - good for responsiveness.
+    "test_pioreactor_HAT_present",
+    "test_all_positive_correlations_between_pds_and_leds",
+    "test_ambient_light_interference",
+    "test_REF_is_lower_than_0_dot_256_volts",
+    "test_REF_is_in_correct_position",
+    "test_PD_is_near_0_volts_for_blank",
+    "test_detect_heating_pcb",
+    "test_positive_correlation_between_temperature_and_heating",
+    "test_positive_correlation_between_rpm_and_stirring",
+    "test_aux_power_is_not_too_high",
+)
 
 
 class SelfTestTimedOut(TimeoutError):
@@ -590,7 +603,7 @@ def get_failed_test_names() -> Iterator[str]:
 
 
 def get_all_test_names() -> Iterator[str]:
-    return (name for name in vars(sys.modules[__name__]).keys() if name.startswith("test_"))
+    return iter(ORDERED_SELF_TEST_NAMES)
 
 
 @click.command(name="self_test")
diff --git a/core/pioreactor/web/static/asset-manifest.json b/core/pioreactor/web/static/asset-manifest.json
@@ -1,7 +1,7 @@
 {
   "files": {
     "main.css": "/static/static/css/main.b7eec0ec.css",
-    "main.js": "/static/static/js/main.16d9b2e7.js",
+    "main.js": "/static/static/js/main.fc06481d.js",
     "static/media/roboto-all-500-normal.woff": "/static/static/media/roboto-all-500-normal.0ab669b7a0d19b178f57.woff",
     "static/media/roboto-all-700-normal.woff": "/static/static/media/roboto-all-700-normal.a457fde362a540fcadff.woff",
     "static/media/roboto-all-400-normal.woff": "/static/static/media/roboto-all-400-normal.c5d001fa922fa66a147f.woff",
@@ -28,10 +28,10 @@
     "static/media/roboto-greek-ext-700-normal.woff2": "/static/static/media/roboto-greek-ext-700-normal.bd9854c751441ccc1a70.woff2",
     "index.html": "/static/index.html",
     "main.b7eec0ec.css.map": "/static/static/css/main.b7eec0ec.css.map",
-    "main.16d9b2e7.js.map": "/static/static/js/main.16d9b2e7.js.map"
+    "main.fc06481d.js.map": "/static/static/js/main.fc06481d.js.map"
   },
   "entrypoints": [
     "static/css/main.b7eec0ec.css",
-    "static/js/main.16d9b2e7.js"
+    "static/js/main.fc06481d.js"
   ]
 }
diff --git a/core/pioreactor/web/static/index.html b/core/pioreactor/web/static/index.html
@@ -1 +1 @@
-<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.16d9b2e7.js"></script><link href="/static/static/css/main.b7eec0ec.css" rel="stylesheet"></head><body><div id="root"></div></body></html>
+<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.fc06481d.js"></script><link href="/static/static/css/main.b7eec0ec.css" rel="stylesheet"></head><body><div id="root"></div></body></html>
diff --git a/core/pioreactor/web/static/static/js/main.fc06481d.js b/core/pioreactor/web/static/static/js/main.fc06481d.js
diff --git a/core/pioreactor/web/static/static/js/main.fc06481d.js.LICENSE.txt b/core/pioreactor/web/static/static/js/main.fc06481d.js.LICENSE.txt
diff --git a/core/pioreactor/web/static/static/js/main.fc06481d.js.map b/core/pioreactor/web/static/static/js/main.fc06481d.js.map
diff --git a/core/tests/test_self_test.py b/core/tests/test_self_test.py
@@ -10,6 +10,7 @@
 os.environ.setdefault("DOT_PIOREACTOR", ".pioreactor")
 
 from pioreactor.actions.self_test import run_tests
+from pioreactor.actions.self_test import get_all_test_names
 
 
 def test_run_tests_success_and_failure_counts() -> None:
@@ -119,3 +120,18 @@ def interrupted(managed_state, logger, unit: str, experiment: str) -> None:
         run_tests([interrupted], managed_state, logger, unit="unit", testing_experiment="experiment")
 
     managed_state.publish_setting.assert_not_called()
+
+
+def test_get_all_test_names_returns_explicit_order() -> None:
+    assert list(get_all_test_names()) == [
+        "test_pioreactor_HAT_present",
+        "test_REF_is_in_correct_position",
+        "test_all_positive_correlations_between_pds_and_leds",
+        "test_ambient_light_interference",
+        "test_REF_is_lower_than_0_dot_256_volts",
+        "test_PD_is_near_0_volts_for_blank",
+        "test_detect_heating_pcb",
+        "test_positive_correlation_between_temperature_and_heating",
+        "test_aux_power_is_not_too_high",
+        "test_positive_correlation_between_rpm_and_stirring",
+    ]
diff --git a/frontend/src/components/Snackbar.jsx b/frontend/src/components/Snackbar.jsx
@@ -67,10 +67,8 @@ export default function Snackbar({
             });
           }
 
-          if (style) {
-            return <div style={style}>{renderedChildren}</div>;
-          }
-          return <>{renderedChildren}</>;
+          // notistack transition needs a ref-able root element (fragments can't receive refs)
+          return <div style={style}>{renderedChildren}</div>;
         }
 
         return <SnackbarContent message={snackMessage} style={style} />;

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.16d9b2e7.js"></script><link href="/static/static/css/main.b7eec0ec.css" rel="stylesheet"></head><body><div id="root"></div></body></html>
	`1`	+<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.fc06481d.js"></script><link href="/static/static/css/main.b7eec0ec.css" rel="stylesheet"></head><body><div id="root"></div></body></html>
Original file line number	Diff line number	Diff line change
`@@ -67,10 +67,8 @@ export default function Snackbar({`
`67`	`67`	`});`
`68`	`68`	`}`
`69`	`69`
`70`		`- if (style) {`
`71`		`- return <div style={style}>{renderedChildren}</div>;`
`72`		`- }`
`73`		`- return <>{renderedChildren}</>;`
	`70`	`+ // notistack transition needs a ref-able root element (fragments can't receive refs)`
	`71`	`+ return <div style={style}>{renderedChildren}</div>;`
`74`	`72`	`}`
`75`	`73`
`76`	`74`	`return <SnackbarContent message={snackMessage} style={style} />;`