Not returning all sets

[LuNoX]

Some querys for sets don't return all sets. For example the query for the bracket with id 273020 using bracket_show_set only returns 1 set with id 6460971. It instead should be returning 3 as seen here.

It does the same with the bracket with id 269808.

I have no idea what could be causing this and it was fine about two weeks ago and now it just doesn't work anymore. My suspicion is that the smash.gg adding the search feature messed with some parts of the api.

[LuNoX]

How would I get pysmash to print its stuff so that I can trace it?

[LuNoX]

I found it:

if bracket_set['winnerId'] is None or bracket_set['loserId'] is None: return None, False

This is my issue. Can you add an arg that disables that part of the code? I only need the sets that haven't been played yet.

[PeterCat12]

Is that tournament currently in progress?

[LuNoX]

I mean it's a test tournament but in theory the matches are in process. It's just that I need the matches that are going to be played, so that I can get the names of the players and notify them. That's what my Discord bot is trying to do.

[PeterCat12]

The reason that I ask is that SmashGG creates set object for sets that will never complete. For example, if two brackets lead into a finals bracket, and only the top 4 people from each pools bracket moves on. See: https://smash.gg/tournament/hidden-bosses-4-0/events/wii-u-singles/brackets/70445/224997.

A set object is created for Dom and Purin even though those two players never played (because they feed into the finals bracket). Currently I do not think there is a way to distinguish between sets like those (useless/dead sets) and sets that are "in progress".

I will try to look into this however.

[PeterCat12]

Also, I have noticed problems with my own application since SmashGGs recent update. What specifically was working/returning properly and now is not?

[LuNoX]

So far it's only been those set return methods. Would appreciate it if they got an arg or _all extension or something so that I could still do my thing.

[PeterCat12]

you used the plural form of "method", which functions specifically would you like that filter on? Also by "working" 2 weeks ago you WERE in fact, getting correct results from these functions previously?

[PeterCat12]

If you look at this commit made 24 days ago, 7ef17c0 this looks like it would affect what it is you're trying to do. However, if it were working 2 weeks ago (assuming you were using an updated master branch at the time) the error would more likely be due to some change on SmashGG's end and not pysmash (since they updated their code ~2 weeks ago). This weekend I will fully investigate this issue as it is holding up my project.

[LuNoX]

tournaments_show_sets and bracket_show_sets

It seems unlikely that I did because if I did that mean that smash.gg must have had something that prevented it from filtering those particular sets. What I think is more likely is that I used some weird way of copying over the files to the bot so that it would work temporarily. This however seems also unlikely since my forked version clearly has that one line...

So I really don't know why it worked, I just know that it did.

[PeterCat12]

sorry to bombard you with messages lol. I get a little frantic sometimes. I appreciate your feedback :)

[LuNoX]

It's fine I'm just slow with responding because I'm testing atm as well.

[PeterCat12]

no worries. Apologies for the problems. I wish that SmashGG's API wasn't the shit show that it is.

[LuNoX]

I mean it is still in development but at least a real doc would be nice...

[PeterCat12]

I would settle for migration logs lol.