Merge pull request #1739 from Permify/fix/handle-os-setenv-errors-gcp-telemetry-logging

fix: handle errors from os.Setenv in GCP telemetry and logging

Author: tolgaozen

internal/engines/subjectFilter.go

@@ -517,10 +517,10 @@ func (engine *SubjectFilter) subjectFilterDirectRelation(
 // setChild generates a SubjectFilterFunction by applying a SubjectFilterCombiner
 // to a set of child permission lookups, given a request and a list of Child objects.
 func (engine *SubjectFilter) setChild(
-	ctx context.Context,                          // The context for carrying out the operation
+	ctx context.Context, // The context for carrying out the operation
 	request *base.PermissionLookupSubjectRequest, // The request containing parameters for lookup
-	children []*base.Child,                       // The children of a particular node in the permission schema
-	combiner SubjectFilterCombiner,               // A function to combine the results from multiple lookup functions
+	children []*base.Child, // The children of a particular node in the permission schema
+	combiner SubjectFilterCombiner, // A function to combine the results from multiple lookup functions
 ) SubjectFilterFunction {
 	var functions []SubjectFilterFunction // Array of functions to store lookup functions for each child
 

pkg/cmd/log.go

@@ -7,14 +7,15 @@ import (
 	"log/slog"
 	"os"
 
-	"github.com/Permify/permify/pkg/telemetry"
-	"github.com/Permify/permify/pkg/telemetry/logexporters"
 	"github.com/Permify/sloggcp"
 	"github.com/agoda-com/opentelemetry-go/otelslog"
+
+	"github.com/Permify/permify/pkg/telemetry"
+	"github.com/Permify/permify/pkg/telemetry/logexporters"
 )
 
 // HandlerFactory - Create log handler according to given params
-func HandlerFactory(name string, endpoint string, insecure bool, urlpath string, headers map[string]string, protocol string, level slog.Leveler) (slog.Handler, error) {
+func HandlerFactory(name, endpoint string, insecure bool, urlpath string, headers map[string]string, protocol string, level slog.Leveler) (slog.Handler, error) {
 	switch name {
 	case "otlp", "otlp-http", "otlp-grpc":
 		return NewOTLPHandler(endpoint, insecure, urlpath, headers, protocol, level.Level())
@@ -53,7 +54,9 @@ func NewGCPHandler(headers map[string]string, level slog.Leveler) (slog.Handler,
 
 	// Set credentials for Google Cloud access
 	if creds != "" {
-		os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", creds)
+		if err := os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", creds); err != nil {
+			return nil, err
+		}
 	}
 
 	// Initialize GCP-specific log handler

pkg/telemetry/meterexporters/gcp.go

@@ -9,9 +9,10 @@ import (
 
 // NewGCP creates a new Google Cloud metric exporter with optional headers for credentials and project ID.
 func NewGCP(headers map[string]string) (metric.Exporter, error) {
-
 	if credentials, exists := headers["google-application-credentials"]; exists && credentials != "" {
-		os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", credentials)
+		if err := os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", credentials); err != nil {
+			return nil, err
+		}
 	}
 
 	if projectID, exists := headers["google-cloud-project"]; exists && projectID != "" {

pkg/telemetry/tracerexporters/gcp.go

@@ -9,9 +9,10 @@ import (
 
 // NewGCP creates a new Google Cloud tracer with optional headers for credentials and project ID.
 func NewGCP(headers map[string]string) (sdktrace.SpanExporter, error) {
-
 	if credentials, exists := headers["google-application-credentials"]; exists && credentials != "" {
-		os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", credentials)
+		if err := os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", credentials); err != nil {
+			return nil, err
+		}
 	}
 
 	if projectID, exists := headers["google-cloud-project"]; exists && projectID != "" {