Build fails on sunos for Perl 5.36.0 thread.h

[rajeshya1]

Module:

Description
We have observed some issues with Perl 5.36.0 thread.h , kindly help us to solve this issue.

bash-4.4$ cc -c -I../../../include -I/scratch/rajeshya/portalbase/publish_solaris_vob/publish_solaris/include -I. -I./include -I../include -DOS_VER=solaris_5.11 -DPIN_USE_ANSI_HDRS -D_REENTRANT -D__unix -D__sun -mt -KPIC -g -DC_VER=unknown -Xa -v -w -O -DPUBLIC= -DFLIST_HEAP -D_PCM_OPS_H -I/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE -o pcmif.o pcmif.c
"/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE/thread.h", line 386: syntax error before or at: void
cc: acomp failed for pcmif.c

CC -mt -xildoff -zdefs -g -L /scratch/rajeshya/portalbase/publish_solaris_vob/publish_solaris/lib -L /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE -G -z nocompstrtab -o pcmif.so -L . pcmif.o -lportal -lpinsys -lpcmext -lCrun -lperl -lnsl -lsocket -lposix4 -lthread -lCrun -lm -lc || ( rm -f pcmif.so; exit 1 )

ld: warning: symbol 'PL_current_context' has differing types:
(file pcmif.o type=OBJT; file /quest/sie/user/rajeshya/tests/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE/libperl.so type=TLS );
ld: fatal: relocation error: R_SPARC_GOTDATA_OP_HIX22: file pcmif.o: symbol PL_current_context: relocation illegal for TLS symbol

Steps to Reproduce

Expected behavior
There should not be any error

Perl configuration

# perl -V output goes here

Summary of my perl5 (revision 5 version 36 subversion 0) configuration:

  Platform:
    osname=solaris
    osvers=2.11
    archname=sun4-solaris-thread-multi-64int-ld
    uname='sunos denac088 5.11 11.3 sun4v sparc sun4v '
    config_args='-des -Dcc=/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/bin/cc -Dusethreads -Dusemorebits -Dprefix=/scratch/Instools/perl-5.36.0/12.0/solaris'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=undef
    uselongdouble=define
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/bin/cc'
    ccflags ='-D_REENTRANT -I/usr/local/include -I/usr/gnu/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPERL_USE_SAFE_PUTENV'
    optimize='-O'
    cppflags='-D_REENTRANT -I/usr/local/include -I/usr/gnu/include'
    ccversion='Studio 12.5 Sun C 5.14 SunOS_sparc 2016/05/31'
    gccversion=''
    gccosandvers=''
    intsize=4
    longsize=4
    ptrsize=4
    doublesize=8
    byteorder=87654321
    doublekind=4
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=2
    ivtype='long long'
    ivsize=8
    nvtype='long double'
    nvsize=16
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/bin/cc'
    ldflags =' -L/usr/lib -L/usr/ccs/lib -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/staticlib -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/sparcvis2 -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers -L/lib -L/usr/local/lib -L/usr/gnu/lib '
    libpth=/usr/lib /usr/ccs/lib /tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/staticlib /tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/sparcvis2 /tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers /lib /usr/local/lib /usr/gnu/lib
    libs=-lpthread -lsocket -lnsl -lgdbm -ldb -ldl -lm -lc -lsunmath
    perllibs=-lpthread -lsocket -lnsl -ldl -lm -lc -lsunmath
    libc=/lib/libc.so
    so=so
    useshrplib=true
    libperl=libperl.so
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='  -R /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE'
    cccdlflags='-KPIC'
    lddlflags='-G -L/usr/lib -L/usr/ccs/lib -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/staticlib -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers/sparcvis2 -L/tools/CGBU/contrib/SunOS/packages/SunStudio/SUNWspro12.5/lib/compilers -L/lib -L/usr/local/lib -L/usr/gnu/lib'


Characteristics of this binary (from libperl):
  Compile-time options:
    HAS_TIMES
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_LONG_DOUBLE
    USE_PERLIO
    USE_PERL_ATOF
    USE_REENTRANT_API
  Built under solaris
  Compiled at Nov 16 2022 02:59:55
  %ENV:
    PERL5INC="/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE"
    PERL5LIB="/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0:/scratch/rajeshya/portalbase/publish_solaris_vob/publish_solaris/lib:/scratch/rajeshya/portalbase/common_vob/build_tools/bin"
    PERL_HOME="/scratch/Instools/perl-5.36.0/12.0//solaris"
  @INC:
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0
    /scratch/rajeshya/portalbase/publish_solaris_vob/publish_solaris/lib
    /scratch/rajeshya/portalbase/common_vob/build_tools/bin
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/site_perl/5.36.0/sun4-solaris-thread-multi-64int-ld
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/site_perl/5.36.0
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld
    /scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0

[iabyn]

On Wed, Nov 16, 2022 at 11:31:49PM -0800, rajeshya1 wrote: We have observed some issues with Perl 5.36.0 thread.h , kindly help us to solve this issue. bash-4.4$ cc -c -I../../../include -I/scratch/rajeshya/portalbase/publish_solaris_vob/publish_solaris/include -I. -I./include -I../include -DOS_VER=solaris_5.11 -DPIN_USE_ANSI_HDRS -D_REENTRANT -D__unix -D__sun -mt -KPIC -g -DC_VER=unknown -Xa -v -w -O -DPUBLIC= -DFLIST_HEAP -D_PCM_OPS_H -I/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE -o pcmif.o pcmif.c "/scratch/Instools/perl-5.36.0/12.0/solaris/lib/5.36.0/sun4-solaris-thread-multi-64int-ld/CORE/thread.h", line 386: syntax error before or at: void cc: acomp failed for pcmif.c

This line is extern PERL_THREAD_LOCAL void *PL_current_context; which was last modified by Nicholas C in v5.35.3-115-g3683a9ee5a, while the #if just above it was also modified by Nicholas C with v5.35.7-47-gc4b6855dd5. I guess once of these is interacting in a bad way with the Solaris C compiler. commit 3683a9e Author: Nicholas Clark ***@***.***> AuthorDate: Sun Jun 20 17:24:15 2021 +0000 Commit: Tony Cook ***@***.***> CommitDate: Tue Sep 7 15:46:16 2021 +1000 If we have thread local storage, use it instead of posix_getspecific(). Declare and use a variable PL_current_context to store a pointer to the thread's interpreter struct. Use this to implement implicit context undef ITHREADS, instead of a call to posix_getspecific(). For normal threaded code, this will eliminate function calls. For threaded code in shared objects (the typical configuration for Linux distribution builds) there still needs to be a function call to get the pointer to thread local variables, but there will only be one per function, not one per read of the variable. commit c4b6855 Author: Nicholas Clark ***@***.***> AuthorDate: Tue Jan 4 18:27:17 2022 +0000 Commit: Nicholas Clark ***@***.***> CommitDate: Wed Jan 12 20:12:50 2022 +0000 For C++ extensions, use the pthreads definition of PERL_GET_CONTEXT Configure probes the C compiler to find out whether it supports C11 thread local storage, and if found uses this for PERL_SET_CONTEXT/PERL_GET_CONTEXT, in preference to the pthread_setspecific()/pthread_getspecific() approach. However, we can come unstuck with XS extensions written in C++, as C++ and C disagree on the syntax used for thread local storage, meaning that the working token that Configure probed for C turns out to be a compiler error on C++. As Configure doesn't have a way to probe for C++ dialects, we just take the safe option and do the same as 5.34.0 and earlier - use pthreads on C++. This commit is minimal because the implementation of PERL_SET_CONTEXT for C11 thread local storage was already defensively written to *also* call pthread_setspecific().

…

-- Justice is when you get what you deserve. Law is when you get what you pay for.

[jkeenan]

@nwc10, Nick, can you comment on this problem?

[tonycoz]

If you're building perl successfully then extensions are managing to link to the symbol in libperl successfully, so we know shared libraries can link successfully.

PERL_THREAD_LOCAL should be defined in config.h, something like:

#define PERL_THREAD_LOCAL _Thread_local /**/

and the build should be picking that up. Is that macro defined to some other symbol?

If nothing else, you should be able to rebuild and supply the -Ud_thread_local option to Configure to build without trying to use _Thread_local.

[tonycoz]

Were you able to solve this yourself?

[mkothar2]

+ Rajesh/Aniruddha

…

________________________________ From: Tony Cook ***@***.***> Sent: Monday, December 5, 2022 9:21 AM To: Perl/perl5 ***@***.***> Cc: MEHUL KOTHARI ***@***.***>; Comment ***@***.***> Subject: [External] : Re: [Perl/perl5] Build fails on sunos for Perl 5.36.0 thread.h (Issue #20523) Were you able to solve this yourself? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/Perl/perl5/issues/20523*issuecomment-1336708508__;Iw!!ACWV5N9M2RV99hQ!Ka9cVwlBFMqzqCbda-4_EYotW7cieA5Wt-S9x71cbVc2rOguoyMQzUhAgp69wWwiNDcLRteyBHO1EvevSudMP_actKc$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AK3ZOKPWHF73QM6IVEFLBPLWLVRCPANCNFSM6AAAAAASDBYPOY__;!!ACWV5N9M2RV99hQ!Ka9cVwlBFMqzqCbda-4_EYotW7cieA5Wt-S9x71cbVc2rOguoyMQzUhAgp69wWwiNDcLRteyBHO1EvevSudMzyi27hc$>. You are receiving this because you commented.Message ID: ***@***.***>

[tonycoz]

Still waiting for a response here.

From the information provided so far this looks like a build issue on your side.