win32.c: don't call wcscpy() with in == out

Since both the input and output parameters are restrict qualified,
this would be invalid, and it is possibe for PerlDir_mapW() to return
its parameter.  This warned on gcc:

win32.c: In function 'win32_link':
win32.c:3712:40: warning: passing argument 1 to 'restrict'-qualified parameter aliases with argument 2 [-Wrestrict]
 3712 |         ((aTHXa(PERL_GET_THX)), wcscpy(wOldName, PerlDir_mapW(wOldName)),
      |                                        ^~~~~~~~

Author: tonycoz

win32/win32.c

@@ -3700,6 +3700,17 @@ win32_pclose(PerlIO *pf)
 #endif /* USE_RTL_POPEN */
 }
 
+/* wcscpy() arguments are restrict qualified, but if they're equal
+   we don't need to do the copy
+*/
+static inline WCHAR *
+cond_wcsncpy(WCHAR *out, const WCHAR *in, size_t n) {
+    assert(wcslen(in) < n);
+    if (out != in)
+        wcsncpy(out, in, n);
+    return out;
+}
+
 DllExport int
 win32_link(const char *oldname, const char *newname)
 {
@@ -3709,7 +3720,8 @@ win32_link(const char *oldname, const char *newname)
 
     if (MultiByteToWideChar(CP_ACP, 0, oldname, -1, wOldName, MAX_PATH+1) &&
         MultiByteToWideChar(CP_ACP, 0, newname, -1, wNewName, MAX_PATH+1) &&
-        ((aTHXa(PERL_GET_THX)), wcscpy(wOldName, PerlDir_mapW(wOldName)),
+        ((aTHXa(PERL_GET_THX)),
+          cond_wcsncpy(wOldName, PerlDir_mapW(wOldName), C_ARRAY_LENGTH(wOldName)),
         CreateHardLinkW(PerlDir_mapW(wNewName), wOldName, NULL)))
     {
         return 0;