Add MANIFEST.SKIP file

This replaces the lists of files to skip in Porting/manicheck,
t/porting/manifest.t and Porting/makerel with a centralized and
standardized MANIFEST.SKIP file.

This would also allow us to add a make manifest target, but I left
that for a follow-up PR.

Author: Leont

MANIFEST

@@ -5128,6 +5128,7 @@ Makefile.SH			A script that generates Makefile
 malloc.c			A version of malloc you might not want
 malloc_ctl.h			A version of malloc you might not want
 MANIFEST			This list of files
+MANIFEST.SKIP			Patterns for files not included in this file
 mathoms.c			A home for binary-compatible code artifacts
 META.json			Distribution meta-data in JSON
 META.yml			Distribution meta-data in YAML

MANIFEST.SKIP

@@ -0,0 +1,6 @@
+\.mailmap
+\.gitignore
+\.gitattributes
+\.git_patch
+^\.git\b
+^\.github/

Porting/makerel

@@ -88,9 +88,7 @@ cleanup($relroot, $reldir) if $opts{c};
 
 print "Cross-checking the MANIFEST...\n";
 my ($missfile, $missentry) = fullcheck();
-@$missentry
-    = grep {$_ !~ m!^\.(?:git|github|mailmap)! and $_ !~ m!(?:/|^)\.gitignore!} @$missentry;
-if (@$missfile ) {
+if (@$missfile) {
     warn "Can't make a release with MANIFEST files missing:\n";
     warn "\t".$_."\n" for (@$missfile);
 }

Porting/manicheck

@@ -8,6 +8,7 @@ use v5.14;
 use warnings;
 use File::Find;
 use Getopt::Long;
+use ExtUtils::Manifest 'maniskip';
 use constant SKIP => 125;
 
 my $exitstatus;
@@ -17,6 +18,7 @@ GetOptions('exitstatus!', \$exitstatus)
 my %files;
 my $missing = 0;
 my $bonus = 0;
+my $skip = maniskip;
 
 open my $fh, '<', 'MANIFEST' or die "Can't read MANIFEST: $!\n";
 for my $line (<$fh>) {
@@ -31,17 +33,11 @@ close $fh;
 find {
     wanted => sub {
         return if -d;
-        return if $_ eq '.mailmap';
-        return if $_ eq '.gitignore';
-        return if $_ eq '.gitattributes';
-        return if $_ eq '.git_patch';
-
-        my $x = $File::Find::name =~ s!^\./!!r;
-        return if $x =~ /^\.git\b/;
-        return if $x =~ m{^\.github/};
-        return if $files{$x};
+        my $path = $File::Find::name =~ s!^\./!!r;
+        return if $skip->($path);
+        return if $files{$path};
         ++$bonus;
-        print "$x\t\tnot in MANIFEST\n";
+        print "$path\t\tnot in MANIFEST\n";
     },
 }, ".";
 

t/porting/manifest.t

@@ -25,6 +25,7 @@
 # correct the problem.
 
 use Config;
+use ExtUtils::Manifest 'maniskip';
 BEGIN {
     @INC = '..' if -f '../TestInit.pm';
 }
@@ -85,14 +86,11 @@ SKIP: {
 
 SKIP: {
     find_git_or_skip(6);
+    my $skip = maniskip;
     my %seen; # De-dup ls-files output (can appear more than once)
     my @repo= grep {
         chomp();
-        !m{\.git_patch$} &&
-        !m{\.gitattributes$} &&
-        !m{\.gitignore$} &&
-        !m{\.mailmap$} &&
-        !m{^\.github/} &&
+        !$skip->($_) &&
         -e $_ &&
         !$seen{$_}++
     } `git ls-files`;