Added strict compiler options and sanitizers

Author: Periecle

.github/workflows/ci.yml

@@ -69,8 +69,8 @@ jobs:
           python -m pip install --upgrade pip
           pip install meson ninja meson-python
 
-      - name: Install package in development mode
-        run: pip install -e ".[dev]"
+      - name: Install package in development mode (strict warnings)
+        run: pip install -e ".[dev]" --config-settings=setup-args="-Dstrict=true"
 
       - name: Run tests with coverage
         run: |
@@ -118,14 +118,51 @@ jobs:
           python -m pip install --upgrade pip
           pip install meson ninja meson-python
 
-      - name: Install package in development mode
-        run: pip install -e ".[dev]"
+      - name: Install package in development mode (strict warnings)
+        run: pip install -e ".[dev]" --config-settings=setup-args="-Dstrict=true"
 
       - name: Run tests
         run: |
           python -X faulthandler -m pytest tests/test_profiler.py -v --tb=short
         timeout-minutes: 5
 
+  # =============================================================================
+  # Memory safety testing with sanitizers (Linux only)
+  # =============================================================================
+  sanitizers:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python 3.12
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Install system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libasan8 libubsan1
+
+      - name: Install build tools
+        run: |
+          python -m pip install --upgrade pip
+          pip install meson ninja meson-python pytest pytest-timeout
+
+      - name: Build with ASAN+UBSAN and strict warnings
+        run: |
+          meson setup builddir --buildtype=debug -Dsanitize=address,undefined -Dstrict=true
+          meson compile -C builddir
+
+      - name: Run tests with sanitizers
+        env:
+          PYTHONPATH: ${{ github.workspace }}/builddir/src/spprof:${{ github.workspace }}/src
+          ASAN_OPTIONS: detect_leaks=1:abort_on_error=1:symbolize=1:halt_on_error=1
+          UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=1
+        run: |
+          python -m pytest tests/ -v --tb=short -x
+        timeout-minutes: 10
+
   # =============================================================================
   # Benchmarks
   # =============================================================================
@@ -144,8 +181,8 @@ jobs:
           python -m pip install --upgrade pip
           pip install meson ninja meson-python
 
-      - name: Install package in development mode
-        run: pip install -e ".[dev]"
+      - name: Install package in development mode (strict warnings)
+        run: pip install -e ".[dev]" --config-settings=setup-args="-Dstrict=true"
 
       - name: Run benchmarks
         run: |

.gitignore

@@ -30,6 +30,9 @@ MANIFEST
 *.dll
 *.dylib
 *.dSYM/
+builddir/
+builddir-asan/
+builddir-pedantic/
 
 # Virtual environments
 .venv/

meson.build

@@ -9,7 +9,7 @@ project(
   meson_version: '>= 1.2.0',
   default_options: [
     'c_std=c11',
-    'warning_level=2',
+    'warning_level=3',
     'buildtype=release',
   ],
 )
@@ -31,15 +31,40 @@ common_c_args = []
 
 if cc.get_id() in ['gcc', 'clang']
   common_c_args += [
-    '-Wno-unused-function',
-    '-Wno-missing-field-initializers',
-    '-Wno-unused-parameter',
+    # Pedantic warnings for high code quality
+    '-pedantic',
+    '-Wextra',
+    '-Wconversion',
+    '-Wsign-conversion',
+    '-Wdouble-promotion',
+    '-Wformat=2',
+    '-Wshadow',
+    '-Wundef',
+    '-Wcast-qual',
+    '-Wwrite-strings',
+    '-Wnull-dereference',
+    # Suppress warnings that are unavoidable in Python C extensions
+    '-Wno-unused-parameter',       # Python API requires 'self' even when unused
+    '-Wno-missing-field-initializers',  # Common with designated initializers
+    # Code generation
     '-fvisibility=hidden',
     '-fPIC',
   ]
+  # GCC-specific warnings
+  if cc.get_id() == 'gcc'
+    common_c_args += [
+      '-Wlogical-op',
+      '-Wduplicated-cond',
+      '-Wduplicated-branches',
+    ]
+  endif
 elif cc.get_id() == 'msvc'
   common_c_args += [
+    '/W4',                        # High warning level
     '/D_CRT_SECURE_NO_WARNINGS',
+    '/wd4100',                    # unreferenced formal parameter (like -Wno-unused-parameter)
+    '/wd4115',                    # named type definition in parentheses (from Python's pytime.h)
+    '/wd4702',                    # unreachable code (false positives from uthash macros)
   ]
 endif
 
@@ -49,6 +74,21 @@ if get_option('buildtype') == 'debug'
   add_project_arguments('-DSPPROF_DEBUG=1', language: 'c')
 endif
 
+# Treat warnings as errors (for CI)
+if get_option('strict')
+  common_c_args += cc.get_id() in ['gcc', 'clang'] ? ['-Werror'] : ['/WX']
+  message('Strict mode: treating warnings as errors')
+endif
+
+# Sanitizer configuration
+sanitize_opt = get_option('sanitize')
+if sanitize_opt != 'none' and cc.get_id() in ['gcc', 'clang']
+  sanitize_args = ['-fsanitize=' + sanitize_opt, '-fno-omit-frame-pointer', '-g']
+  common_c_args += sanitize_args
+  add_project_link_arguments(sanitize_args, language: 'c')
+  message('Sanitizers enabled: ' + sanitize_opt)
+endif
+
 # Version defines
 add_project_arguments(
   '-DSPPROF_PY_MAJOR=' + py_major,

meson_options.txt

@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: MIT
+# meson_options.txt - Build options for spprof
+
+option('sanitize', type: 'combo', choices: ['none', 'address', 'undefined', 'address,undefined'],
+       value: 'none',
+       description: 'Enable sanitizers (ASAN/UBSAN)')
+
+option('strict', type: 'boolean', value: false,
+       description: 'Treat warnings as errors (recommended for CI)')
+

src/spprof/_ext/code_registry.c

@@ -259,7 +259,7 @@ void code_registry_release_ref(uintptr_t code_addr) {
     }
 }
 
-void code_registry_release_refs_batch(uintptr_t* code_addrs, size_t count) {
+void code_registry_release_refs_batch(const uintptr_t* code_addrs, size_t count) {
     if (!g_initialized || code_addrs == NULL || count == 0) {
         return;
     }

src/spprof/_ext/code_registry.h

@@ -160,7 +160,7 @@ void code_registry_release_ref(uintptr_t code_addr);
  * @param code_addrs Array of raw PyCodeObject* pointers.
  * @param count      Number of pointers in the array.
  */
-void code_registry_release_refs_batch(uintptr_t* code_addrs, size_t count);
+void code_registry_release_refs_batch(const uintptr_t* code_addrs, size_t count);
 
 /**
  * Validate a code object pointer (REQUIRES GIL).

src/spprof/_ext/error.h

@@ -57,6 +57,26 @@
 extern "C" {
 #endif
 
+/*
+ * =============================================================================
+ * COMPILER PORTABILITY MACROS
+ * =============================================================================
+ */
+
+/**
+ * SPPROF_UNUSED - Mark a function or variable as intentionally unused.
+ *
+ * Suppresses "unused function" or "unused variable" warnings across compilers.
+ * Use when a function is conditionally used or kept for future use.
+ */
+#if defined(_MSC_VER)
+#define SPPROF_UNUSED /* MSVC doesn't warn about static unused functions */
+#elif defined(__GNUC__) || defined(__clang__)
+#define SPPROF_UNUSED __attribute__((unused))
+#else
+#define SPPROF_UNUSED
+#endif
+
 /**
  * SpResult - Common result type for operations that can fail in multiple ways
  *

src/spprof/_ext/internal/pycore_tstate.h

@@ -499,7 +499,7 @@ _spprof_capture_frames_extended(
         if (_spprof_ptr_valid(code)) {
             frames[count].code_ptr = (uintptr_t)code;
             frames[count].instr_ptr = (uintptr_t)_spprof_frame_get_instr_ptr(frame);
-            frames[count].owner = _spprof_frame_get_owner(frame);
+            frames[count].owner = (int8_t)_spprof_frame_get_owner(frame);
             count++;
         }
 
@@ -525,7 +525,7 @@ _spprof_capture_frames_extended(
         if (_spprof_ptr_valid(code)) {
             frames[count].code_ptr = (uintptr_t)code;
             frames[count].instr_ptr = (uintptr_t)_spprof_frame_get_instr_ptr(frame);
-            frames[count].owner = _spprof_frame_get_owner(frame);
+            frames[count].owner = (int8_t)_spprof_frame_get_owner(frame);
             count++;
         }
 

src/spprof/_ext/module.c

@@ -62,7 +62,24 @@ static void spprof_cleanup(void);
  * Internal function. Use spprof.start() from Python.
  */
 static PyObject* spprof_start(PyObject* self, PyObject* args, PyObject* kwargs) {
+    /* Note: PyArg_ParseTupleAndKeywords expects char**, not const char**.
+     * This is a limitation of Python's C API. We suppress the warning locally.
+     * GCC uses -Wdiscarded-qualifiers, Clang uses -Wincompatible-pointer-types-discards-qualifiers. */
+#if defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wwrite-strings"
+#pragma clang diagnostic ignored "-Wincompatible-pointer-types-discards-qualifiers"
+#elif defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wwrite-strings"
+#pragma GCC diagnostic ignored "-Wdiscarded-qualifiers"
+#endif
     static char* kwlist[] = {"interval_ns", NULL};
+#if defined(__clang__)
+#pragma clang diagnostic pop
+#elif defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
     uint64_t interval_ns = 10000000;  /* Default 10ms */
 
     if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|K", kwlist, &interval_ns)) {
@@ -618,7 +635,7 @@ static PyObject* spprof_get_code_registry_stats(PyObject* self, PyObject* args)
 
 /* Method table */
 static PyMethodDef SpProfMethods[] = {
-    {"_start", (PyCFunction)spprof_start, METH_VARARGS | METH_KEYWORDS,
+    {"_start", (PyCFunction)(void(*)(void))spprof_start, METH_VARARGS | METH_KEYWORDS,
      "Start profiling (internal). Use spprof.start() instead."},
     {"_stop", spprof_stop, METH_NOARGS,
      "Stop profiling and return raw samples (internal, legacy API)."},

src/spprof/_ext/platform/darwin_mach.c

@@ -57,6 +57,7 @@
 #include "darwin_mach.h"
 #include "../ringbuffer.h"
 #include "../code_registry.h"
+#include "../error.h"
 
 /* Internal API for Python frame capture */
 #ifdef SPPROF_USE_INTERNAL_API
@@ -108,7 +109,8 @@ static void mach_debug_log(const char* fmt, ...) {
 }
 #define MACH_DEBUG(fmt, ...) mach_debug_log(fmt, ##__VA_ARGS__)
 #else
-#define MACH_DEBUG(fmt, ...) ((void)0)
+/* Accept any arguments but discard them - avoids C23 variadic warning */
+#define MACH_DEBUG(...) ((void)0)
 #endif
 
 /*
@@ -717,6 +719,7 @@ static int write_mixed_sample_to_ringbuffer(
 /**
  * Write a captured Python stack to the ring buffer (legacy, no native frames).
  */
+SPPROF_UNUSED
 static int write_python_sample_to_ringbuffer(
     uint64_t thread_id,
     uint64_t timestamp,
@@ -732,6 +735,7 @@ static int write_python_sample_to_ringbuffer(
 /**
  * Write a captured native stack to the ring buffer (for native-only mode).
  */
+SPPROF_UNUSED
 static int write_native_sample_to_ringbuffer(const CapturedStack* stack, 
                                              RingBuffer* ringbuffer) {
     RawSample sample;
@@ -1000,6 +1004,7 @@ static void sample_all_threads(ThreadSnapshot* snapshot, MachSamplerState* state
 /**
  * Legacy single-thread sample function (not used in current implementation).
  */
+SPPROF_UNUSED
 static int sample_thread(ThreadEntry* entry, MachSamplerState* state) {
     (void)entry;
     (void)state;
@@ -1129,7 +1134,7 @@ void mach_sampler_cleanup(void) {
 
     /* Remove introspection hook */
     if (g_state.registry.hook_installed) {
-        pthread_introspection_hook_install(g_state.registry.prev_hook);
+        (void)pthread_introspection_hook_install(g_state.registry.prev_hook);
         g_state.registry.hook_installed = 0;
     }