Keep hostnames lowercase in Styx

Author: oyvhvi

Styx/Services/ClientRegistry.cs

@@ -40,7 +40,7 @@ public async ValueTask Unregister(string connectionId)
         using var clients = await _clients.WaitForDisposable();
         foreach (var (connectionId, identity) in clients.Value)
         {
-            if (identity.NetworkId == networkId && identity.HostName.EqualsIgnoreCase(hostName))
+            if (identity.NetworkId == networkId && identity.HostName.EqualsOrdinal(hostName))
                 return connectionId;
         }
         return null;
@@ -58,7 +58,7 @@ public async ValueTask<IReadOnlyList<string>> KickDuplicates(Guid networkId, str
         using var clients = await _clients.WaitForDisposable();
         var found = clients.Value
             .Where(kv => kv.Value.NetworkId == networkId
-                && kv.Value.HostName.EqualsIgnoreCase(hostName)
+                && kv.Value.HostName.EqualsOrdinal(hostName)
                 && kv.Key != newConnectionId)
             .Select(kv => kv.Key)
             .ToList();

Styx/Services/PeerBroadcastService.cs

@@ -48,12 +48,12 @@ private async Task BroadcastPeers(Guid networkId)
         try
         {
             var clients = await registry.GetNetworkClients(networkId);
-            var allHostNames = clients.Select(c => c.HostName).OrderBy(h => h, StringComparer.OrdinalIgnoreCase).ToArray();
+            var allHostNames = clients.Select(c => c.HostName).OrderBy(h => h, StringComparer.Ordinal).ToArray();
             var peerList = allHostNames.Length > 0 ? string.Join(", ", allHostNames) : "<none>";
             log.LogInformation("Network {NetworkId} peers: {Peers}", networkId, peerList);
             foreach (var (connectionId, hostName) in clients)
             {
-                var peers = allHostNames.Where(h => !h.EqualsIgnoreCase(hostName)).ToArray();
+                var peers = allHostNames.Where(h => !h.EqualsOrdinal(hostName)).ToArray();
                 await hubContext.Clients.Client(connectionId).Peers(peers);
             }
         }

Styx/StyxHub.cs

@@ -36,18 +36,20 @@ public async Task<RelayLoginResponse> Authenticate(RelayLogin login)
         }
         catch (Exception ex)
         {
-            log.LogWarning(ex, "Authentication failed for \"{HostName}\" from {RemoteIp}", login.HostName, remoteIp);
+            log.LogWarning(ex, "Authentication failed for \"{HostName}\" from {RemoteIp}", login.HostName.ToLowerInvariant(), remoteIp);
             await throttle;
             return new RelayLoginResponse { Authenticated = false, Message = "Invalid authorization" };
         }
 
+        var hostName = login.HostName.ToLowerInvariant();
+
         // kick any existing connections with the same network+hostname (stale entries can accumulate on unclean disconnect)
-        var kicked = await registry.KickDuplicates(networkId, login.HostName, Context.ConnectionId);
+        var kicked = await registry.KickDuplicates(networkId, hostName, Context.ConnectionId);
         foreach (var connectionId in kicked)
             await Clients.Client(connectionId).Kicked("duplicate hostname");
 
-        await registry.Register(Context.ConnectionId, networkId, login.HostName, remoteIp);
-        log.LogInformation("Authentication accepted for \"{HostName}\" (connectionId:{ConnectionId}) from {RemoteIp} on network {NetworkId}", login.HostName, Context.ConnectionId, remoteIp, networkId);
+        await registry.Register(Context.ConnectionId, networkId, hostName, remoteIp);
+        log.LogInformation("Authentication accepted for \"{HostName}\" (connectionId:{ConnectionId}) from {RemoteIp} on network {NetworkId}", hostName, Context.ConnectionId, remoteIp, networkId);
         await throttle;
 
         // queue after throttle so Authenticated=true is sent to the caller before Peers arrives
@@ -81,7 +83,7 @@ public async Task Send(string[] targetHosts, byte[] payload)
                 continue;
             }
 
-            var targetConnectionId = await registry.GetConnectionId(identity.NetworkId, targetHost);
+            var targetConnectionId = await registry.GetConnectionId(identity.NetworkId, targetHost.ToLowerInvariant());
             if (targetConnectionId == null)
             {
                 log.LogDebug("Target {TargetHost} not found on network {NetworkId}", targetHost, identity.NetworkId);