-
Notifications
You must be signed in to change notification settings - Fork 10
Add Project env for miniapps #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
I would stay with GLMakie for now as Cairo doesn't like it when the cmin = cmax which happens during the plotting of the Shearbands |
| @@ -0,0 +1,8 @@ | |||
| [deps] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add GMG, ExactFieldSolutions (which then can be rm in the root project.toml).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
I see, the one issue though with GLMakie is that it would fail when running on headless machines or servers where no OpenGL context is available. Isn't there a workaround for the shear band case? Else, we could also just add explicitly in the shear band case? |
|
I guess we could add some random noise to the plots so that its not all the same values |
This seems to work though with CairoMakie (v0.15.7): |
|
I'll try to add a ref to it in the docs and then ask for review. |
This PR adds a Project file in order to allow quick start running a JR miniapp example.
Todos (or maybe):