Skip to content

Conversation

@luraess
Copy link
Member

@luraess luraess commented Nov 26, 2025

This PR adds a Project file in order to allow quick start running a JR miniapp example.

Todos (or maybe):

  • Add CUDA?, MPI to env
  • Add plotting packages to the env, CairoMakie or GLMakie
  • Add note to the doc about how to get started with the miniapps
  • anything else?

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aelligp
Copy link
Collaborator

aelligp commented Nov 27, 2025

I would stay with GLMakie for now as Cairo doesn't like it when the cmin = cmax which happens during the plotting of the Shearbands

@@ -0,0 +1,8 @@
[deps]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GMG, ExactFieldSolutions (which then can be rm in the root project.toml).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@luraess
Copy link
Member Author

luraess commented Nov 27, 2025

I would stay with GLMakie for now as Cairo doesn't like it when the cmin = cmax which happens during the plotting of the Shearbands

I see, the one issue though with GLMakie is that it would fail when running on headless machines or servers where no OpenGL context is available. Isn't there a workaround for the shear band case? Else, we could also just add explicitly

import Pkg; Pkg.add("GLMakie"); using GLMakie

in the shear band case?

@albert-de-montserrat
Copy link
Collaborator

I guess we could add some random noise to the plots so that its not all the same values

@luraess
Copy link
Member Author

luraess commented Nov 27, 2025

I would stay with GLMakie for now as Cairo doesn't like it when the cmin = cmax which happens during the plotting of the Shearbands

This seems to work though with CairoMakie (v0.15.7):

using CairoMakie
heatmap(zeros(2,2))

@luraess
Copy link
Member Author

luraess commented Nov 27, 2025

I'll try to add a ref to it in the docs and then ask for review.

@luraess luraess marked this pull request as ready for review December 2, 2025 08:18
@luraess luraess merged commit 36bb299 into main Dec 2, 2025
19 of 22 checks passed
@luraess luraess deleted the lr/miniapps branch December 2, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants