Skip to content

Commit a335523

Browse files
SR20290919SR20290919
authored andcommitted
creating constant for duplicates
1 parent 172aef2 commit a335523

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

src/main/java/com/iemr/tm/service/generalOPD/GeneralOPDServiceImpl.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ public class GeneralOPDServiceImpl implements GeneralOPDService {
8787

8888
private static final String VITAL_DETAILS = "vitalDetails";
8989

90-
90+
private static final String EXAMINATION_DETAILS = "examinationDetails";
91+
92+
private static final String HISTORY_DETAILS = "historyDetails";
9193

9294
@Autowired
9395
private CommonNurseServiceImpl commonNurseServiceImpl;
@@ -153,10 +155,10 @@ public String saveNurseData(JsonObject requestOBJ, String Authorization) throws
153155
// create tc request
154156
tcRequestOBJ = commonServiceImpl.createTcRequest(requestOBJ, nurseUtilityClass, Authorization);
155157
// call method to save History data
156-
if (requestOBJ.has("historyDetails") && !requestOBJ.get("historyDetails").isJsonNull()) {
158+
if (requestOBJ.has(HISTORY_DETAILS) && !requestOBJ.get(HISTORY_DETAILS).isJsonNull()) {
157159
logger.info("Start saving BenGeneralOPDHistoryDetails for BenVisitID={} and BenVisitCode={}", benVisitID, benVisitCode);
158160
historySaveSuccessFlag = saveBenGeneralOPDHistoryDetails(
159-
requestOBJ.getAsJsonObject("historyDetails"), benVisitID, benVisitCode);
161+
requestOBJ.getAsJsonObject(HISTORY_DETAILS), benVisitID, benVisitCode);
160162
if (historySaveSuccessFlag == null || historySaveSuccessFlag <= 0) {
161163
logger.error("Error in saving BenGeneralOPDHistoryDetails for BenVisitID={} and BenVisitCode={}", benVisitID, benVisitCode);
162164
} else {
@@ -177,9 +179,9 @@ public String saveNurseData(JsonObject requestOBJ, String Authorization) throws
177179
}
178180

179181
// call method to save examination data
180-
if (requestOBJ.has("examinationDetails") && !requestOBJ.get("examinationDetails").isJsonNull()) {
182+
if (requestOBJ.has(EXAMINATION_DETAILS) && !requestOBJ.get(EXAMINATION_DETAILS).isJsonNull()) {
181183
logger.info("Start saving BenExaminationDetails for BenVisitID={} and BenVisitCode={}", benVisitID, benVisitCode);
182-
examtnSaveSuccessFlag = saveBenExaminationDetails(requestOBJ.getAsJsonObject("examinationDetails"),
184+
examtnSaveSuccessFlag = saveBenExaminationDetails(requestOBJ.getAsJsonObject(EXAMINATION_DETAILS),
183185
benVisitID, benVisitCode);
184186
if (examtnSaveSuccessFlag == null || examtnSaveSuccessFlag <= 0) {
185187
logger.error("Error in saving BenExaminationDetails for BenVisitID={} and BenVisitCode={}", benVisitID, benVisitCode);

0 commit comments

Comments
 (0)