Don't use latched keys with a physical keyboard

[ellbur]

First, thank you for all the work you've put into this excellent project.

I noticed that with a physical keyboard attached by USB, modifier keys latch.

Normally latching is a setting of the keyboard layout, which can be controlled through an XKB file of the kind Wayland uses. I did some poking through the current code, and it seems like some portion of the latching behavior is hard-coded.

I'm wondering if this functionality can be moved to a keyboard layout so that it can be more easily turned on and off?

Below is the output from wev:

[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000000
                      latched: 00000001: Shift 
                      locked: 00000000
[13:     wl_keyboard] key: serial: 1112; time: 1007244; key: 50; state: 1 (pressed)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000001: Shift 
                      latched: 00000001: Shift 
                      locked: 00000000
[13:     wl_keyboard] key: serial: 1114; time: 1007353; key: 50; state: 0 (released)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000000
                      latched: 00000001: Shift 
                      locked: 00000000
[13:     wl_keyboard] modifiers: serial: 0; group: 1
                      depressed: 00000000
                      latched: 00000000
                      locked: 00000001: Shift 
[13:     wl_keyboard] key: serial: 1117; time: 1007856; key: 50; state: 1 (pressed)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 1
                      depressed: 00000001: Shift 
                      latched: 00000000
                      locked: 00000001: Shift 
[13:     wl_keyboard] key: serial: 1119; time: 1007962; key: 50; state: 0 (released)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 1
                      depressed: 00000000
                      latched: 00000000
                      locked: 00000001: Shift 
[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000000
                      latched: 00000000
                      locked: 00000000
[13:     wl_keyboard] key: serial: 1122; time: 1008316; key: 50; state: 1 (pressed)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000001: Shift 
                      latched: 00000000
                      locked: 00000000
[13:     wl_keyboard] key: serial: 1124; time: 1008422; key: 50; state: 0 (released)
                      sym: Shift_L      (65505), utf8: ''
[13:     wl_keyboard] modifiers: serial: 0; group: 0
                      depressed: 00000000
                      latched: 00000000
                      locked: 00000000

[m-weigand]

Thanks for reporting this issue. However, I am not aware of any specific changes I made to the image that could have caused this. Still, it may be something I did by accident. If you find anything, I will be happy to fix things - otherwise I would suggest to look into opening a bug for Debian trixie.

[ellbur]

Interesting. I will take a look.

[ellbur]

It turns out it's just the stickykeys setting:

pinenote-debian-image/overlays/gnome_config/01-pinenote-settings

Lines 16 to 18 in 1343e4d

	[org/gnome/desktop/a11y/keyboard]
	mousekeys-enable=false
	stickykeys-enable=true

I suppose that was added to improve the on-screen keyboard?

I guess there's no reason to change that, then, since people who don't want it can just turn it off.