Failing unit tests

[rushi]

Hey Guys,

I'd like to use the library but there are a lot of failing unit tests - https://travis-ci.org/PHPOffice/PHPExcel/builds Example: https://travis-ci.org/PHPOffice/PHPExcel/jobs/43296917 has 152 failures.

Is this indicative of broken features or broken tests? I'd like to help out but fixing so many tests is quite a reach for a developer new to the project.

[MarkBaker]

If you look at the actual failing tests, most of them are precision issues in the calculation engine (oddly, PHPExcel is accurate to a higher degree of precision than MS Excel itself) while others are test fro RAND() or TODAY() functions and similar which should probably be skipped. There are very few tests that actually fail (Matrix Inversion being one that springs to mind).... and (unfortunately) very few tests for features.

It's also a big reach for the PHPExcel development team to fix them all, but the product itself is very stable despite those failing tests

[rushi]

Thanks @MarkBaker

[PatrickRose]

I've been looking at this because I'll be using this in an upcoming project.

The date tests seem to have some inconsistencies. 29th Feb 1900 is expected to return a 60, but 29th Feb 2007 is expected to return #VALUE!. Which should it be?

There's also oddities in how date_parse works - the test for 22/8/08 is returning the value for the date 8th August 2022 (instead of 22nd August 2008).

Is there a good place I could collate these findings, or should I just put them on this ticket?

[PatrickRose]

The date tests seem to have some inconsistencies. 29th Feb 1900 is expected to return a 60, but 29th Feb 2007 is expected to return #VALUE!. Which should it be?

It's been pointed out to me today that 29th Feb 1900 should return 60 due to legacy Excel reasons...