Sly 2: Band of Thieves Cutscene and FMV Skip

[jacobmix]

Added Sly 2: Band of Thieves Cutscene and FMV Skip
Read more: https://github.com/andshrew/Sly2-Cutscene-Skip/tree/main

[pgert]

The filenames of the pnachs are off.
Have you even tested them - do the hack show up in the menu?
Change the names into:

"SCES-52529_15DD1F6F.v2.01.Cutscene-Skip.pnach" -> "SCES-52529_15DD1F6F.pnach"
"SCES-52529_FDA1CBF6.v1.00.Cutscene-Skip.pnach" -> "SCES-52529_FDA1CBF6.pnach"
"SCKA-20044_518DD841.Cutscene-Skip.pnach" -> "SCKA-20044_518DD841.pnach"
"SCPS-15090_615EA2DB.Cutscene-Skip.pnach" -> "SCPS-15090_615EA2DB.pnach"
"SCUS-97316_07652DD9.Cutscene-Skip.pnach" -> "SCUS-97316_07652DD9.pnach"

Some of these pnachs are already in the archive, so just add the hack to those.

[PeterDelta]

The errors mentioned seem serious to me since they prevent progress:

    As mentioned above, there were issues that can be caused from skipping some cutscenes too early; and some cutscenes cannot be skipped. Some examples of issues which were reported for the official implementation include:

    Episode 4: Eavesdrop on Contessa - Last cutscene. This just doesn't spawn the Train Hack job trigger. This is preventable by waiting for Bentley to turn around fully in his monologue.
    Episode 6: Aerial Assault - First cutscene on the train. The chopper doesn't get into position correctly and it becomes impossible to progress
    Skipping a few cutscenes on the first possible frame can end up in a softlock, usually the ones ending a job. (Steal a Tuxedo, Cabin Crimes)

[jacobmix]

@pgert thanks for the heads up. Fixed it.
When i tested just having SCUS-97316_07652DD9.Cutscene-Skip.pnach in patches worked. (If not on hardcore mode)
@PeterDelta kind of worried about that too. Tho it's such a massive QoL i still think it's worth adding. But if it won't be approved before future improvements i understand.
Hopefully there's a chance that an improved version of the feature will return to the official release at some point in the future.
Else someone with more experience of both Sly 2 modding and PCSX2 patch creation may be able to significantly improve on this.